From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Jelle van der Waa <jelle@vdwaa.nl>
Subject: Re: [PATCH 1/2] perf/ui/gtk: Add missing zalloc object
Date: Tue, 14 Jan 2020 12:25:30 -0300 [thread overview]
Message-ID: <20200114152530.GA20569@kernel.org> (raw)
In-Reply-To: <20200113104358.123511-1-jolsa@kernel.org>
Em Mon, Jan 13, 2020 at 11:43:57AM +0100, Jiri Olsa escreveu:
> When we moved zalloc.o to the library we missed gtk library
> which needs it compiled in, otherwise the missing __zfree
> symbol will cause the library to fail to load.
>
> Adding the zalloc object to the gtk library build.
Thanks, applied.
- Arnaldo
> Fixes: 7f7c536f23e6 ("tools lib: Adopt zalloc()/zfree() from tools/perf")
> Link: https://lkml.kernel.org/n/tip-nuu3lyzzmi2t9zdvlg0i0bh0@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/ui/gtk/Build | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
> index ec22e899a224..9b5d5cbb7af7 100644
> --- a/tools/perf/ui/gtk/Build
> +++ b/tools/perf/ui/gtk/Build
> @@ -7,3 +7,8 @@ gtk-y += util.o
> gtk-y += helpline.o
> gtk-y += progress.o
> gtk-y += annotate.o
> +gtk-y += zalloc.o
> +
> +$(OUTPUT)ui/gtk/zalloc.o: ../lib/zalloc.c FORCE
> + $(call rule_mkdir)
> + $(call if_changed_dep,cc_o_c)
> --
> 2.24.1
>
--
- Arnaldo
next prev parent reply other threads:[~2020-01-14 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 10:43 [PATCH 1/2] perf/ui/gtk: Add missing zalloc object Jiri Olsa
2020-01-13 10:43 ` [PATCH 2/2] perf/ui/gtk: Fix gtk2 build Jiri Olsa
2020-01-14 15:41 ` Arnaldo Carvalho de Melo
2020-01-20 8:27 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2020-01-14 15:25 ` Arnaldo Carvalho de Melo [this message]
2020-01-20 8:27 ` [tip: perf/core] perf ui gtk: Add missing zalloc object tip-bot2 for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114152530.GA20569@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=jelle@vdwaa.nl \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).