From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9BEC33C9E for ; Tue, 14 Jan 2020 16:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEB4824655 for ; Tue, 14 Jan 2020 16:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728689AbgANQTO (ORCPT ); Tue, 14 Jan 2020 11:19:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:32838 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726839AbgANQTO (ORCPT ); Tue, 14 Jan 2020 11:19:14 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6F27DAB7D; Tue, 14 Jan 2020 16:19:12 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 9840CDA730; Tue, 14 Jan 2020 17:18:57 +0100 (CET) Date: Tue, 14 Jan 2020 17:18:57 +0100 From: David Sterba To: Mikhail Zaslonko Cc: Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Richard Purdie , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Eduard Shishkin , Ilya Leoshkevich , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] btrfs: Use larger zlib buffer for s390 hardware compression Message-ID: <20200114161857.GD3929@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Mikhail Zaslonko , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Richard Purdie , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Eduard Shishkin , Ilya Leoshkevich , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200107143058.GU3929@twin.jikos.cz> <20200108105103.29028-1-zaslonko@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200108105103.29028-1-zaslonko@linux.ibm.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 11:51:03AM +0100, Mikhail Zaslonko wrote: > In order to benefit from s390 zlib hardware compression support, > increase the btrfs zlib workspace buffer size from 1 to 4 pages (if > s390 zlib hardware support is enabled on the machine). This brings up > to 60% better performance in hardware on s390 compared to the PAGE_SIZE > buffer and much more compared to the software zlib processing in btrfs. > In case of memory pressure, fall back to a single page buffer during > workspace allocation. > The data compressed with larger input buffers will still conform to zlib > standard and thus can be decompressed also on a systems that uses only > PAGE_SIZE buffer for btrfs zlib. > > Signed-off-by: Mikhail Zaslonko Reviewed-by: David Sterba