From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353B1C33CB3 for ; Tue, 14 Jan 2020 16:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C2F22053B for ; Tue, 14 Jan 2020 16:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728863AbgANQgO (ORCPT ); Tue, 14 Jan 2020 11:36:14 -0500 Received: from mga07.intel.com ([134.134.136.100]:60465 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbgANQgO (ORCPT ); Tue, 14 Jan 2020 11:36:14 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 08:36:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,433,1574150400"; d="scan'208";a="242532965" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 14 Jan 2020 08:36:07 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1irPAm-0000us-6K; Tue, 14 Jan 2020 18:36:08 +0200 Date: Tue, 14 Jan 2020 18:36:08 +0200 From: Andy Shevchenko To: "fengping.yu" Cc: Dmitry Torokhov , Rob Herring , Marco Felsch , Matthias Brugger , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 2/2] drivers: input: keyboard: add mtk keypad driver Message-ID: <20200114163608.GY32742@smile.fi.intel.com> References: <20200114122738.103344-1-fengping.yu@mediatek.com> <20200114122738.103344-3-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114122738.103344-3-fengping.yu@mediatek.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2020 at 08:27:41PM +0800, fengping.yu wrote: > Signed-off-by: fengping.yu > > Add matrix keypad driver for MTK SoC. Something wrong with ordering. ... > +obj-$(CONFIG_KEYBOARD_MTK) += mtk-kpd.o TABs / space mix. I think you ignored my comment. ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include ... > +#define KPD_DEBOUNCE_MASK GENMASK_ULL(13, 0) ULL? Why? ... > +static void kpd_get_keymap_state(void __iomem *kp_base, u32 state[]) u32 *state > +{ > + memset_io(state, 0xff, KPD_NUM_MEMS); This is strange. What is this for and why is it needed? > + memcpy_fromio(state, kp_base, KPD_NUM_MEMS); > +} ... > +static irqreturn_t kpd_irq_handler(int irq, void *dev_id) > +{ > + /* use _nosync to avoid deadlock */ > + struct mtk_keypad *keypad = dev_id; > + unsigned short *keycode = keypad->input_dev->keycode; > + u32 new_state[KPD_NUM_MEMS], mask; > + unsigned long change = 0; > + int bit_nr; > + int pressed; > + u32 row_shift = get_count_order(keypad->n_cols); > + unsigned short code; > + int i; > + > + disable_irq_nosync(keypad->irqnr); > + > + kpd_get_keymap_state(keypad->base, new_state); > + > + for (i = 0; i < KPD_NUM_MEMS; i++) { > + change = new_state[i] ^ keypad->keymap_state[i]; > + if (!change) > + continue; > + > + for_each_set_bit(bit_nr, &change, 32) { > + mask = 1 << bit_nr; > + pressed = (new_state[i] & mask) == 0U; test_bit() ? Can't new_state be unsigned long? In this case you may get rid of outer loop I suppose. > + dev_dbg(&keypad->input_dev->dev, > + "%s", pressed ? "pressed" : "released"); > + > + code = keycode[MATRIX_SCAN_CODE(i, bit_nr, row_shift)]; > + > + input_report_key(keypad->input_dev, code, pressed); > + input_sync(keypad->input_dev); > + > + dev_dbg(&keypad->input_dev->dev, > + "report Linux keycode = %d\n", code); > + } > + } > + > + memcpy(keypad->keymap_state, new_state, sizeof(new_state)); > + > + enable_irq(keypad->irqnr); > + > + return IRQ_HANDLED; > +} ... > +static int kpd_get_dts_info(struct mtk_keypad *keypad) > +{ > + int ret; > + struct device *dev = keypad->input_dev->dev.parent; > + struct device_node *node = dev->of_node; > + > + ret = matrix_keypad_parse_properties(dev, &keypad->n_rows, > + &keypad->n_cols); > + Redundant line. > + if (ret) { > + dev_err(dev, "failed to parse keypad params.\n"); > + return ret; > + } > + > + ret = of_property_read_u32(node, "mediatek,debounce-us", > + &keypad->key_debounce); > + if (ret) { > + pr_debug("read mediatek,debounce-us error.\n"); dev_dbg() ? > + return ret; > + } > + > + keypad->wakeup = of_property_read_bool(node, "wakeup-source"); > + > + dev_dbg(dev, "n_row=%d n_col=%d debounce=%d.\n", > + keypad->n_rows, keypad->n_cols, > + keypad->key_debounce); > + > + return 0; > +} ... > +static int kpd_gpio_init(struct device *dev) > +{ > + struct pinctrl *keypad_pinctrl; > + struct pinctrl_state *kpd_default; > + > + keypad_pinctrl = devm_pinctrl_get(dev); > + if (IS_ERR(keypad_pinctrl)) { > + dev_err(dev, "Cannot find keypad_pinctrl!\n"); > + Redundant line > + return PTR_ERR(keypad_pinctrl); > + } > + > + kpd_default = pinctrl_lookup_state(keypad_pinctrl, "default"); > + if (IS_ERR(kpd_default)) { > + dev_err(dev, "Cannot find ecall_state!\n"); > + Ditto. > + return PTR_ERR(kpd_default); > + } > + > + return pinctrl_select_state(keypad_pinctrl, kpd_default); > +} ... > + int err; err or ret? Be consistent with the name of variable that keeps returned code. > + if (!pdev->dev.of_node) { > + dev_err(&pdev->dev, "No device tree data present.\n"); > + return -EINVAL; > + } I think this is redundant. below calls will fail when property is not found. > + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL); > + if (!keypad) > + return -ENOMEM; > + > + memset(keypad->keymap_state, 0xff, sizeof(keypad->keymap_state)); bitmap_fill() ? > + err = matrix_keypad_build_keymap(NULL, NULL, > + keypad->n_rows, > + keypad->n_cols, > + NULL, > + keypad->input_dev); > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + dev_err(&pdev->dev, "get IO memory resource failed.\n"); > + return -ENODEV; > + } > + > + keypad->base = devm_ioremap_resource(&pdev->dev, res); devm_platform_ioremap_resource() > + if (IS_ERR(keypad->base)) { > + dev_err(&pdev->dev, "KP iomap failed\n"); > + return PTR_ERR(keypad->base); > + } > + > + writew((keypad->key_debounce * 32 / 1000 & KPD_DEBOUNCE_MASK), Useless parentheses. It's not lisp! > + keypad->base + KP_DEBOUNCE); > + err = clk_prepare_enable(keypad->clk); > + if (err) { > + dev_err(&pdev->dev, "kpd-clk prepare enable failed.\n"); > + return err; > + } > + > + err = kpd_gpio_init(&pdev->dev); > + if (err) { > + dev_err(&pdev->dev, "gpio init failed\n"); > + return err; Starting from here down the clocks left in a wrong state. > + } > + > + keypad->irqnr = platform_get_irq(pdev, 0); > + if (!keypad->irqnr) { This is wrong... > + dev_err(&pdev->dev, "KP get irqnr failed\n"); > + return -EINVAL; ...and so does this. > + } -- With Best Regards, Andy Shevchenko