From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36317C33C9E for ; Tue, 14 Jan 2020 16:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3D3F2084D for ; Tue, 14 Jan 2020 16:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579021071; bh=I7zCUFSxCilOiygfJOrKMG+d9QBWeV+zMVpsSsqTMqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rd0TkOcXkw6dLf0zS840E766DsNCTppnE68subUtQIEuKAb+6ziEYkIAxSp58pGqH xMddoXr7/GGVtCQjWYHQrKqCGF7gxqyA9AYTKtfULDkTc/dMyYaEgsWjCp/NeR2lrn tVw91Bu9X8CMBag2pbgw6fnV8xj51k7/drGcHDho= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728765AbgANQ5u (ORCPT ); Tue, 14 Jan 2020 11:57:50 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34292 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbgANQ5t (ORCPT ); Tue, 14 Jan 2020 11:57:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I7zCUFSxCilOiygfJOrKMG+d9QBWeV+zMVpsSsqTMqc=; b=kWHKHJJ6ilFEWZ2bNlW/Xb26V zGRDUEUZTnDadH1LnqM1ADZMn4ilWGec89HluanPHUxhNrpUyJ3xZqFAI5s2Q4E86vFSN9IF7T4Nf gKE/KbbvYrjzJ3hSOsZPEkWNhP/YMZAWYoawaW2j8vSPiJajqf9hZ0l7gGfmHbxfE3+PY=; Received: from fw-tnat-cam7.arm.com ([217.140.106.55] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irPVc-0001hW-7R; Tue, 14 Jan 2020 16:57:40 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id ACA3ED01965; Tue, 14 Jan 2020 16:57:39 +0000 (GMT) Date: Tue, 14 Jan 2020 16:57:39 +0000 From: Mark Brown To: Joakim Tjernlund Cc: "christophe.leroy@c-s.fr" , "linux-spi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lkp@intel.com" , "geert@linux-m68k.org" Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe() Message-ID: <20200114165739.GC3897@sirena.org.uk> References: <2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="avNtfD0ffNO6L/9g" Content-Disposition: inline In-Reply-To: X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --avNtfD0ffNO6L/9g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 14, 2020 at 04:26:18PM +0000, Joakim Tjernlund wrote: > Don't you need to "undo" ioremap, irq etc. in case of later errors? Better, convert to devm_=20 --avNtfD0ffNO6L/9g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4d8wIACgkQJNaLcl1U h9DBpgf/ZMWk7TuStHKbaJC0YfEaWwp2D/yVzYAISxxSeNvL25vQlQlFJe6YGYR0 2KK5vLMxNaH1Vf6vhet00ClpsdinZt7Jx91tzaplblsKxlPbraf4tSs6USCdy5Iq kSgUDnJvxiQSMnoTjJOkMh/ee/2LJQtVnYB+XirIqI9YWfqAZLrgm/PfqUnNq5vG +g9nCJ3/RKsLQGb9VmbmXwMy5gVCj3u41aMoX9XDDgoayy1IZPWRIsBTIzUmmCLZ A5OhXxnxucHDkAMXjiHE+jmgPEC1LUV+JIBydgN7Z+ryBNvTeLXDTFbnavabBb3Q RaQCF+kEphOgL9A5QfgIkwmkUwtCtg== =SVwD -----END PGP SIGNATURE----- --avNtfD0ffNO6L/9g--