From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>,
stable@vger.kernel.org, Rich Felker <dalias@libc.org>,
libc-alpha@sourceware.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc32: fix struct ipc64_perm type definition
Date: Wed, 15 Jan 2020 01:10:23 +0300 [thread overview]
Message-ID: <20200114221023.GA8853@altlinux.org> (raw)
In-Reply-To: <20200114132633.3694261-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 2495 bytes --]
On Tue, Jan 14, 2020 at 02:26:14PM +0100, Arnd Bergmann wrote:
> As discussed in the strace issue tracker, it appears that the sparc32
> sysvipc support has been broken for the past 11 years. It was however
> working in compat mode, which is how it must have escaped most of the
> regular testing.
>
> The problem is that a cleanup patch inadvertently changed the uid/gid
> fields in struct ipc64_perm from 32-bit types to 16-bit types in uapi
> headers.
>
> Both glibc and uclibc-ng still use the original types, so they should
> work fine with compat mode, but not natively. Change the definitions
> to use __kernel_uid32_t and __kernel_gid32_t again.
>
> Fixes: 83c86984bff2 ("sparc: unify ipcbuf.h")
> Link: https://github.com/strace/strace/issues/116
> Cc: <stable@vger.kernel.org> # v2.6.29
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: "Dmitry V . Levin" <ldv@altlinux.org>
> Cc: Rich Felker <dalias@libc.org>
> Cc: libc-alpha@sourceware.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/sparc/include/uapi/asm/ipcbuf.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/sparc/include/uapi/asm/ipcbuf.h b/arch/sparc/include/uapi/asm/ipcbuf.h
> index 5b933a598a33..0ea1240d2ea1 100644
> --- a/arch/sparc/include/uapi/asm/ipcbuf.h
> +++ b/arch/sparc/include/uapi/asm/ipcbuf.h
> @@ -17,19 +17,19 @@
>
> struct ipc64_perm
> {
> - __kernel_key_t key;
> - __kernel_uid_t uid;
> - __kernel_gid_t gid;
> - __kernel_uid_t cuid;
> - __kernel_gid_t cgid;
> + __kernel_key_t key;
> + __kernel_uid32_t uid;
> + __kernel_gid32_t gid;
> + __kernel_uid32_t cuid;
> + __kernel_gid32_t cgid;
> #ifndef __arch64__
> - unsigned short __pad0;
> + unsigned short __pad0;
> #endif
> - __kernel_mode_t mode;
> - unsigned short __pad1;
> - unsigned short seq;
> - unsigned long long __unused1;
> - unsigned long long __unused2;
> + __kernel_mode_t mode;
> + unsigned short __pad1;
> + unsigned short seq;
> + unsigned long long __unused1;
> + unsigned long long __unused2;
> };
>
> #endif /* __SPARC_IPCBUF_H */
I think the fix is correct, I also confirm that the part of strace
test suite that checks tracing of 32-bit tracees on sparc64 turns green
again when this patch is applied.
Please add to the commit message that
this bug was found by strace test suite.
Feel free to add
Reported-and-tested-by: Dmitry V. Levin <ldv@altlinux.org>
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2020-01-14 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 13:26 [PATCH] sparc32: fix struct ipc64_perm type definition Arnd Bergmann
2020-01-14 22:10 ` Dmitry V. Levin [this message]
2020-01-21 12:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114221023.GA8853@altlinux.org \
--to=ldv@altlinux.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=libc-alpha@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).