From: Michal Hocko <mhocko@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com,
pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org,
david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk()
Date: Wed, 15 Jan 2020 15:46:29 +0100 [thread overview]
Message-ID: <20200115144629.GG19428@dhcp22.suse.cz> (raw)
In-Reply-To: <39D75B58-A5CE-4837-BCD3-8026E2C88861@lca.pw>
On Wed 15-01-20 07:35:45, Qian Cai wrote:
>
>
> > On Jan 15, 2020, at 4:22 AM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > Is this correct? CMA pages cannot be comound?
>
> I never saw a CMA page also a compound page. Also, in
> alloc_contig_range(), it calls migrate_pages()—>
> unmap_and_move_huge_page() which will free the old huge page, so I
> think that will clear pageCompound.
This sounds like the implementation detail. I do not think you want to
depend on that. Anyway, see my other response. If you rebase on top of
Vlastimil's patch you do not really have to care.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-01-15 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 5:31 [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk() Qian Cai
2020-01-15 9:22 ` Michal Hocko
2020-01-15 9:24 ` Michal Hocko
2020-01-15 12:35 ` Qian Cai
2020-01-15 14:46 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115144629.GG19428@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).