From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA2BC32771 for ; Wed, 15 Jan 2020 22:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E60022522 for ; Wed, 15 Jan 2020 22:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730717AbgAOWiq (ORCPT ); Wed, 15 Jan 2020 17:38:46 -0500 Received: from mga07.intel.com ([134.134.136.100]:1576 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbgAOWip (ORCPT ); Wed, 15 Jan 2020 17:38:45 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 14:38:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,323,1574150400"; d="scan'208";a="398050726" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 15 Jan 2020 14:38:44 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1irrJF-0002Y8-I7; Thu, 16 Jan 2020 00:38:45 +0200 Date: Thu, 16 Jan 2020 00:38:45 +0200 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] tty: baudrate: Synchronise baud_table[] and baud_bits[] Message-ID: <20200115223845.GI32742@smile.fi.intel.com> References: <20200114170917.36947-1-andriy.shevchenko@linux.intel.com> <20200114172756.GA2052011@kroah.com> <20200115163327.GF32742@smile.fi.intel.com> <20200115172106.GA4127163@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115172106.GA4127163@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 06:21:06PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 15, 2020 at 06:33:27PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 14, 2020 at 06:27:56PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Jan 14, 2020 at 07:09:17PM +0200, Andy Shevchenko wrote: > > > > Synchronize baud rate tables for better readability. > > > > > > "Synchronize"? With what? > > > > Between each other. This SPARC thingy makes it's harder to follow. > > Ok, be more specific please, a better changelog is key here. > > > > Why? I'm all for cleaning up code, but this > > > just seems totally gratuitous. > > > > Btw, while doing it I found that SPARC actually supports more baud rates than > > defined in those arrays. Without this patch I would not (easily) notice that. > > Should I also attach another patch and resend? > > Yes, that might justify this patch's acceptance :) Done in v2. -- With Best Regards, Andy Shevchenko