From: David Miller <davem@davemloft.net>
To: madhuparnabhowmik04@gmail.com
Cc: gregkh@linuxfoundation.org, paulmck@kernel.org,
joel@joelfernandes.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
frextrite@gmail.com
Subject: Re: [PATCH] net: wan: lapbether.c: Use built-in RCU list checking
Date: Thu, 16 Jan 2020 05:31:07 -0800 (PST) [thread overview]
Message-ID: <20200116.053107.2118682332070479073.davem@davemloft.net> (raw)
In-Reply-To: <20200115114101.13068-1-madhuparnabhowmik04@gmail.com>
From: madhuparnabhowmik04@gmail.com
Date: Wed, 15 Jan 2020 17:11:01 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> The only callers of the function lapbeth_get_x25_dev()
> are lapbeth_rcv() and lapbeth_device_event().
>
> lapbeth_rcv() uses rcu_read_lock() whereas lapbeth_device_event()
> is called with RTNL held (As mentioned in the comments).
>
> Therefore, pass lockdep_rtnl_is_held() as cond argument in
> list_for_each_entry_rcu();
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Applied.
prev parent reply other threads:[~2020-01-16 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:41 [PATCH] net: wan: lapbether.c: Use built-in RCU list checking madhuparnabhowmik04
2020-01-16 13:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116.053107.2118682332070479073.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).