linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	f.fainelli@gmail.com, hkallweit1@gmail.com
Subject: Re: [PATCH 2/4] net: phy: adin: rename struct adin_hw_stat -> adin_map
Date: Thu, 16 Jan 2020 14:38:05 +0100	[thread overview]
Message-ID: <20200116133805.GC19046@lunn.ch> (raw)
In-Reply-To: <20200116091454.16032-3-alexandru.ardelean@analog.com>

On Thu, Jan 16, 2020 at 11:14:52AM +0200, Alexandru Ardelean wrote:
> The structure format will be re-used in an upcoming change. This change
> renames to have a more generic name.

NACK.

Defining a new structure does not cost you anything. And you get type
checking, so if you were to pass a adin_map adin_ge_io_pins to a stats
function, the compiler will warn.

	  Andrew

  reply	other threads:[~2020-01-16 13:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16  9:14 [PATCH 0/4] net: phy: adin: implement support for 1588 start-of-packet indication Alexandru Ardelean
2020-01-16  9:14 ` [PATCH 1/4] net: phy: adin: const-ify static data Alexandru Ardelean
2020-01-16 13:30   ` Andrew Lunn
2020-01-16  9:14 ` [PATCH 2/4] net: phy: adin: rename struct adin_hw_stat -> adin_map Alexandru Ardelean
2020-01-16 13:38   ` Andrew Lunn [this message]
2020-01-16 13:57     ` Ardelean, Alexandru
2020-01-16  9:14 ` [PATCH 3/4] net: phy: adin: implement support for 1588 start-of-packet indication Alexandru Ardelean
2020-01-16 13:55   ` Andrew Lunn
2020-01-16 13:58     ` Ardelean, Alexandru
2020-01-16 14:02       ` Andrew Lunn
2020-01-16 14:03         ` Ardelean, Alexandru
2020-01-16  9:14 ` [PATCH 4/4] dt-bindings: net: adin: document 1588 TX/RX SOP bindings Alexandru Ardelean
2020-01-16 13:43   ` Andrew Lunn
2020-01-16 14:00     ` Ardelean, Alexandru
2020-01-22  2:05   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116133805.GC19046@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandru.ardelean@analog.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).