From: Ido Schimmel <idosch@mellanox.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jakub Kicinski <kuba@kernel.org>,
Hongbo Yao <yaohongbo@huawei.com>,
"chenzhou10@huawei.com" <chenzhou10@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
mlxsw <mlxsw@mellanox.com>
Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
Date: Thu, 16 Jan 2020 14:04:01 +0000 [thread overview]
Message-ID: <20200116140359.GA1817679@splinter> (raw)
In-Reply-To: <20200116135412.GK2131@nanopsycho>
On Thu, Jan 16, 2020 at 02:56:50PM +0100, Jiri Pirko wrote:
> Thu, Jan 16, 2020 at 02:31:37PM CET, kuba@kernel.org wrote:
> >On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> >> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> >> Building drivers/net/netdevsim/fib.o will get the following error:
> >>
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> >> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> >> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
> >>
> >> Correct the Kconfig for netdevsim.
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
> >
> >Looks better :) Still missing a space between the hash and the bracket,
> >but:
> >
> >Acked-by: Jakub Kicinski <kuba@kernel.org>
> >
> >While at it - does mlxsw have the same problem by any chance?
>
> Looks like it does.
MLXSW_SPECTRUM depends on NET_SWITCHDEV which in turn depends on INET
next prev parent reply other threads:[~2020-01-16 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 13:14 [PATCH v2 -next] drivers/net: netdevsim depends on INET Hongbo Yao
2020-01-16 13:31 ` Jakub Kicinski
2020-01-16 13:56 ` Jiri Pirko
2020-01-16 14:04 ` Ido Schimmel [this message]
2020-01-17 10:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116140359.GA1817679@splinter \
--to=idosch@mellanox.com \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).