From: Andrew Morton <akpm@linux-foundation.org>
To: Qian Cai <cai@lca.pw>
Cc: Alex Shi <alex.shi@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
Date: Thu, 16 Jan 2020 15:37:35 -0800 [thread overview]
Message-ID: <20200116153735.3090629f3b40bd850c66bd18@linux-foundation.org> (raw)
In-Reply-To: <B6E75D9E-E9A2-4078-A89A-267310467B0A@lca.pw>
On Thu, 16 Jan 2020 07:26:23 -0500 Qian Cai <cai@lca.pw> wrote:
>
>
> > On Jan 14, 2020, at 9:33 PM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
> >
> >
> >
> >> 在 2020/1/14 下午9:46, Qian Cai 写道:
> >>
> >>
> >>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
> >>>
> >>> This macro are never used in git history. So better to remove.
> >>
> >> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
> >>
> >
> > Thanks fore reminder, Qian!
> >
> > This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or commiter could be found.
>
> Looks a bit deeper for this, and I am not sure if it is necessary to remove it especially this does not cause any complication warning noise, because the macro looks like a part of API design to have a pair of both read and write version, even though only the write version is used at the moment.
>
> In theory, there could be users for the read version in the future, and then it needs to be added back.
Sure. A problem with leaving it in place is that this leads people to
assume it is tested, which it presumably is not.
I don't think there's any particular downside either way, really. But
it's presently cruft so I'm inclined to remove it. If someone has a
need then they can add it back (presumbly reimplement it, actually) and
test it then.
next prev parent reply other threads:[~2020-01-16 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:55 [PATCH] mm/vmscan: remove prefetch_prev_lru_page Alex Shi
2020-01-14 13:46 ` Qian Cai
2020-01-15 2:31 ` Alex Shi
2020-01-16 12:26 ` Qian Cai
2020-01-16 23:37 ` Andrew Morton [this message]
2020-01-16 13:18 ` Guoqing Jiang
2020-01-15 8:29 ` Christoph Hellwig
2020-01-15 18:27 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116153735.3090629f3b40bd850c66bd18@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).