From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E07C33CB1 for ; Thu, 16 Jan 2020 16:49:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F25D1214AF for ; Thu, 16 Jan 2020 16:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193351; bh=QQYpEbf31hkSDbiEAbjq25eEmaC/NfNiXzP4hhLzfbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oaExjvvZDn8Vy4wx/B0OOtC+5d+gV2vQMZ8oMImcpPJ5NjV8KzEeIRugU2DBEm3ir vSgCNiK7ErdcTEr1HYefcGQrEiJKAP64n8kfbhS69e3zUyyzZPaZq0CETcsEG2OnAJ tKH7Xy+CSR2+F+vPBwvyJVJZM1LEaRV1VA27ne+c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730302AbgAPQtK (ORCPT ); Thu, 16 Jan 2020 11:49:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:59874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730106AbgAPQtH (ORCPT ); Thu, 16 Jan 2020 11:49:07 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53248207FF; Thu, 16 Jan 2020 16:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193346; bh=QQYpEbf31hkSDbiEAbjq25eEmaC/NfNiXzP4hhLzfbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=slirQ+xSx4WcXQ5fDsMGv4JOicFULjoxvqok/p2OTUwRD/D8w+CEtDtYhF38OAo6d KVlHOrA6odxibLlvQN6Nitvam2P4xXbaNRm4Wp44OsYQkMnAGezqYm4xlQ7IJWxzPY SKeqPRW2z6+LzSZ1BN1uNH9Sy5k2WjlX5TEAaReM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hewenliang , Lorenzo Pieralisi , Kishon Vijay Abraham I , Sasha Levin , linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 079/205] tools: PCI: Fix fd leakage Date: Thu, 16 Jan 2020 11:40:54 -0500 Message-Id: <20200116164300.6705-79-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116164300.6705-1-sashal@kernel.org> References: <20200116164300.6705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hewenliang [ Upstream commit 3c379a59b4795d7279d38c623e74b9790345a32b ] We should close fd before the return of run_test. Fixes: 3f2ed8134834 ("tools: PCI: Add a userspace tool to test PCI endpoint") Signed-off-by: Hewenliang Signed-off-by: Lorenzo Pieralisi Acked-by: Kishon Vijay Abraham I Signed-off-by: Sasha Levin --- tools/pci/pcitest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index cb1e51fcc84e..32b7c6f9043d 100644 --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -129,6 +129,7 @@ static int run_test(struct pci_test *test) } fflush(stdout); + close(fd); return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */ } -- 2.20.1