From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C116DC33CB7 for ; Thu, 16 Jan 2020 16:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8909020730 for ; Thu, 16 Jan 2020 16:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193945; bh=fuBXMvSTLfDbGUI2JonKdv73O1O0F8tSvwYVNKXzwZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NpEilH6oT/RLThs3w7SSTSc/FHZ0o0LPaem+g9tIsyyhrG5slZh0teCQ+iY5+idMJ 7CoFFPtKDNuvF7krYgH8+0waRLRjdid/ICfYh9vW5D4du28eMU5O+2LUY6ClYyfOK2 N6hGEwDCMhZTW6T+OZPKyjwjly3sKQPbJcyTU7J8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387509AbgAPQ5c (ORCPT ); Thu, 16 Jan 2020 11:57:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:44426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387476AbgAPQ5V (ORCPT ); Thu, 16 Jan 2020 11:57:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE9B42468A; Thu, 16 Jan 2020 16:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193840; bh=fuBXMvSTLfDbGUI2JonKdv73O1O0F8tSvwYVNKXzwZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UnOaPdzD4VXkd6L1wrhGzdRA4vnvWuGVAImUpinlNI3azOtyiboMeyfXhKIiSSWE7 eS7SCtT84vj/aNB5YY9VeUuCxpzvta95xfFlvBMAfIEyxR4N7pnhcgmLDTS6IhsOZt 5hpQ/v1Maen+MiHddtMGzf8ZVjLlyGei1R+t0+io= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yangtao Li , Gregory CLEMENT , Stephen Boyd , Sasha Levin , linux-clk@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 095/671] clk: armada-xp: fix refcount leak in axp_clk_init() Date: Thu, 16 Jan 2020 11:45:26 -0500 Message-Id: <20200116165502.8838-95-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165502.8838-1-sashal@kernel.org> References: <20200116165502.8838-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit db20a90a4b6745dad62753f8bd2f66afdd5abc84 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Reviewed-by: Gregory CLEMENT Fixes: 0a11a6ae9437 ("clk: mvebu: armada-xp: maintain clock init order") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/mvebu/armada-xp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c index 0ec44ae9a2a2..df529982adc9 100644 --- a/drivers/clk/mvebu/armada-xp.c +++ b/drivers/clk/mvebu/armada-xp.c @@ -228,7 +228,9 @@ static void __init axp_clk_init(struct device_node *np) mvebu_coreclk_setup(np, &axp_coreclks); - if (cgnp) + if (cgnp) { mvebu_clk_gating_setup(cgnp, axp_gating_desc); + of_node_put(cgnp); + } } CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init); -- 2.20.1