From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B77C33CAF for ; Thu, 16 Jan 2020 17:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC23E22525 for ; Thu, 16 Jan 2020 17:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194028; bh=IipMnTXhBIxyAvhtlYI+7dCiLvBs2w2RwqoI+ysNijA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JDa4v+bOSzKJGLnZUGrjvPfIfVAohUCGogf09G0iVodDxBwWtqEEfMMz0PZ2NT/Yd I3DfXTwUy2cNbgZscZlLYRfulecQgOfkqy/W2CbmMAMnWLzIBINgda5ZJXRBuyYwxW UbFoCjRERePoguAE4mdDSP7Du9T8m90t+It3/NF4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387758AbgAPRAZ (ORCPT ); Thu, 16 Jan 2020 12:00:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:49764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387722AbgAPRAR (ORCPT ); Thu, 16 Jan 2020 12:00:17 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B19222525; Thu, 16 Jan 2020 17:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194016; bh=IipMnTXhBIxyAvhtlYI+7dCiLvBs2w2RwqoI+ysNijA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G2dX9xknjjZnKXXnCJTh8mp7CcIqfHeYB6FD7CmkksE5POZZpaEofxRbUgfpPPZL4 QxQfGNSQz2fmWvZmTjFClhqiX8qYlq1OuEmFrGvcp+453KwPswcRuaEUrnnw+Re4b4 uVErlxk1BmfDJc6R3XhsJ8B+Jvre1ZXHPyRSmDj4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: YueHaibing , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.19 138/671] tty: ipwireless: Fix potential NULL pointer dereference Date: Thu, 16 Jan 2020 11:50:47 -0500 Message-Id: <20200116165940.10720-21-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165940.10720-1-sashal@kernel.org> References: <20200116165940.10720-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 7dd50e205b3348dc7784efbdf85723551de64a25 ] There is a potential NULL pointer dereference in case alloc_ctrl_packet() fails and returns NULL. Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem") Signed-off-by: YueHaibing Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/ipwireless/hardware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c index b0baa4ce10f9..6bbf35682d53 100644 --- a/drivers/tty/ipwireless/hardware.c +++ b/drivers/tty/ipwireless/hardware.c @@ -1516,6 +1516,8 @@ static void ipw_send_setup_packet(struct ipw_hardware *hw) sizeof(struct ipw_setup_get_version_query_packet), ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP, TL_SETUP_SIGNO_GET_VERSION_QRY); + if (!ver_packet) + return; ver_packet->header.length = sizeof(struct tl_setup_get_version_qry); /* -- 2.20.1