From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FAA4C33CB6 for ; Thu, 16 Jan 2020 18:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 331F520684 for ; Thu, 16 Jan 2020 18:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199135; bh=UzWpqtykFIuIk/3wDH9HC2fhJkTy90NGFF7wu0Zh//A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GQZIzLLXGQNvQVKlTIXhT/VtnvdYKNNETyQlhbNPWxpNuqxsw8kavewEDPTzSVv44 NPhE5zE/Up8WBzIUumuozFwghHJx+z8yRxPDqRMcuILJXZeWc8rDvG7Du/c7yGOgg6 zElVYWc6IXD6dsJNfWvgde57q3CWSXFU5NpomnpE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392356AbgAPR05 (ORCPT ); Thu, 16 Jan 2020 12:26:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:35976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392316AbgAPR0t (ORCPT ); Thu, 16 Jan 2020 12:26:49 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1DA1246C8; Thu, 16 Jan 2020 17:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195609; bh=UzWpqtykFIuIk/3wDH9HC2fhJkTy90NGFF7wu0Zh//A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1KlyXxOKgsbY7xHC2pbfKDP3YnPEJ3Y7jOuSp2vbu6j/OkHqe2rw/nO5/9txqcEcu WP8qpx6Sr/vyPpAL2QaN2KjEjZBUGQsZf+0llD3i63D5+dYsbmw7ld3U4Fmdqj+ZyS F0Ce0NehMDGQgk4Zmi3d+sSQzx+kjghiOXOALQ0M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sameeh Jubran , Arthur Kiyanovski , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 183/371] net: ena: fix: Free napi resources when ena_up() fails Date: Thu, 16 Jan 2020 12:20:55 -0500 Message-Id: <20200116172403.18149-126-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sameeh Jubran [ Upstream commit b287cdbd1cedfc9606682c6e02b58d00ff3a33ae ] ena_up() calls ena_init_napi() but does not call ena_del_napi() in case of failure. This causes a segmentation fault upon rmmod when netif_napi_del() is called. Fix this bug by calling ena_del_napi() before returning error from ena_up(). Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Arthur Kiyanovski Signed-off-by: Sameeh Jubran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index d22b138c2b09..518ff393a026 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -1796,6 +1796,7 @@ static int ena_up(struct ena_adapter *adapter) err_setup_tx: ena_free_io_irq(adapter); err_req_irq: + ena_del_napi(adapter); return rc; } -- 2.20.1