From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BD2C33CAF for ; Thu, 16 Jan 2020 18:25:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 856072051A for ; Thu, 16 Jan 2020 18:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199109; bh=k/giQLTQHP1E1fL/X5OrnR5YwPGCnPWgGQwz2XUq7mA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pnvkZq6zeLoO/3lc0r/ivgEOsnb0ybsnXANpGDSky3bUPvVA6T68LvnbGpzSnVZyk Gd3kVnMuF3WyOrDNGpbNZRjjY8xsIJOaU/Q77o4WJF0P3AKIT/hYmvATfScKKlntS6 EEInnhQzrvD9o3rz5730pNSrmiVIPtQqNdcrjzF8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392391AbgAPR1D (ORCPT ); Thu, 16 Jan 2020 12:27:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:36140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392343AbgAPR0z (ORCPT ); Thu, 16 Jan 2020 12:26:55 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9607246D4; Thu, 16 Jan 2020 17:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195614; bh=k/giQLTQHP1E1fL/X5OrnR5YwPGCnPWgGQwz2XUq7mA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T/OVRGSbb2t4OHUE+SbV9ZQo8KjxysCDZhO8IH81xGtQtyqcuGDX4qiBz4dE81qvJ bV8owEcCZ2fAXhTN1vk5t0mz14jv6OWY3WqawCfryoz4lzQqa9WQ6oK/QoWls5vbAq b30+PxUCpvQHHI73LZrUVYfAIGE/1jomSVkdTKhE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pan Bian , Ulf Hansson , Sasha Levin , linux-mmc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 187/371] mmc: core: fix possible use after free of host Date: Thu, 16 Jan 2020 12:20:59 -0500 Message-Id: <20200116172403.18149-130-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 8e1943af2986db42bee2b8dddf49a36cdb2e9219 ] In the function mmc_alloc_host, the function put_device is called to release allocated resources when mmc_gpio_alloc fails. Finally, the function pointed by host->class_dev.class->dev_release (i.e., mmc_host_classdev_release) is used to release resources including the host structure. However, after put_device, host is used and released again. Resulting in a use-after-free bug. Fixes: 1ed217194488 ("mmc: core: fix error path in mmc_host_alloc") Signed-off-by: Pan Bian Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/core/host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index ad88deb2e8f3..3740fb0052a4 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -376,8 +376,6 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) if (mmc_gpio_alloc(host)) { put_device(&host->class_dev); - ida_simple_remove(&mmc_host_ida, host->index); - kfree(host); return NULL; } -- 2.20.1