From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDD2C33CAF for ; Thu, 16 Jan 2020 17:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06530246A1 for ; Thu, 16 Jan 2020 17:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196013; bh=D4koUEZyoEWnZ7PH6TZzuDnLbMuD8YMIatB3LvF3vQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=p5wD0tQv3q9KtDIxA3YjHGVPkBp1BZ7SYBRyGrZsGDR8RfnoNeVHvrhVg+5kCPyTv +Jc5eAdQJKbEPXneL0hHApc6jcO0zPeqQ9GJEKyeMyTWTf3pHXZaDVAi1k1EQgloNh U6+8CqEnQWgoGWtgsiT8HHa0GU+Qmr0GdvLWo72s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404707AbgAPRdc (ORCPT ); Thu, 16 Jan 2020 12:33:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:43058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404245AbgAPRa1 (ORCPT ); Thu, 16 Jan 2020 12:30:27 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE90224726; Thu, 16 Jan 2020 17:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195826; bh=D4koUEZyoEWnZ7PH6TZzuDnLbMuD8YMIatB3LvF3vQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wezxv6d3p8dF3sAolIjNA+iX49Sw8FWf4SUEFLIr0YIYOdCR1V40twa0V32wkVOaZ ht4msTpWOY8LK8aEj9Qtj4YR48xswkovGZO0r8Cqv2/tijOO4yTYie5G0GDTRd9elM /vLZa7DY3U7HGuAby9dIh0iYA0k8r0z0PuIaZ7os= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Colin Ian King , Tony Lindgren , Linus Walleij , Sasha Levin , linux-gpio@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 334/371] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call Date: Thu, 16 Jan 2020 12:23:26 -0500 Message-Id: <20200116172403.18149-277-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 5ff8aca906f3a7a7db79fad92f2a4401107ef50d ] The call to pinctrl_count_index_with_args checks for a -EINVAL return however this function calls pinctrl_get_list_and_count and this can return -ENOENT. Rather than check for a specific error, fix this by checking for any error return to catch the -ENOENT case. Addresses-Coverity: ("Improper use of negative") Fixes: 003910ebc83b ("pinctrl: Introduce TI IOdelay configuration driver") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20190920122030.14340-1-colin.king@canonical.com Acked-by: Tony Lindgren Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c index 5c1b6325d80d..8ac1f1ce4442 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -496,7 +496,7 @@ static int ti_iodelay_dt_node_to_map(struct pinctrl_dev *pctldev, return -EINVAL; rows = pinctrl_count_index_with_args(np, name); - if (rows == -EINVAL) + if (rows < 0) return rows; *map = devm_kzalloc(iod->dev, sizeof(**map), GFP_KERNEL); -- 2.20.1