From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ABBFC33CAF for ; Thu, 16 Jan 2020 23:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D10B3206D9 for ; Thu, 16 Jan 2020 23:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217301; bh=ocAANWlWEdcaXT6VbO9RDlKzdJkJnLOESxnJLG+KFdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vQOnQ6JZBMJfc/qN+73Bli3IHsPZ901fzrK9a0UF2gkjkgD/qqBauy6nq1nCE1s+V hoV66kAkdzejvS/4EiHctIjrV4elU6AjSgX0aQbDxDaRC+ve+MDMc8Ub0sJvLwFSW+ ybltm8H4XGKHRpMSeW7OY/qsWKRWaARXo4xs5P6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391094AbgAPX2V (ORCPT ); Thu, 16 Jan 2020 18:28:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:60930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390734AbgAPX2P (ORCPT ); Thu, 16 Jan 2020 18:28:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94D4620684; Thu, 16 Jan 2020 23:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217294; bh=ocAANWlWEdcaXT6VbO9RDlKzdJkJnLOESxnJLG+KFdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzihyre7pjoVDGFiknGoCfTnLMTZ6kPGxfAyUJ8ju3Iu/r4mqfKrXb315iTXfv5Wd gXUsWLhuWakz9QaJG08e0dkAGzKZeA/1+TfyQMBQD/PEXIsiWQI1JXxTdEed2bdCVr njGdeYecaYgfsZ7WDQKu+pW/ps9Sqjq7gi3yhOEY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaro Koskinen , Peter Ujfalusi , "H. Nikolaus Schaller" , Miquel Raynal Subject: [PATCH 4.19 23/84] mtd: onenand: omap2: Pass correct flags for prep_dma_memcpy Date: Fri, 17 Jan 2020 00:17:57 +0100 Message-Id: <20200116231716.388547311@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Ujfalusi commit 8bcef0d54067077cf9a6cb129022c77559926e8c upstream. The commit converting the driver to DMAengine was missing the flags for the memcpy prepare call. It went unnoticed since the omap-dma driver was ignoring them. Fixes: 3ed6a4d1de2c5 (" mtd: onenand: omap2: Convert to use dmaengine for memcp") Reported-by: Aaro Koskinen Signed-off-by: Peter Ujfalusi Tested-by: H. Nikolaus Schaller Tested-by: Aaro Koskinen Signed-off-by: Miquel Raynal Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/onenand/omap2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mtd/nand/onenand/omap2.c +++ b/drivers/mtd/nand/onenand/omap2.c @@ -341,7 +341,8 @@ static inline int omap2_onenand_dma_tran struct dma_async_tx_descriptor *tx; dma_cookie_t cookie; - tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, 0); + tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, + DMA_CTRL_ACK | DMA_PREP_INTERRUPT); if (!tx) { dev_err(&c->pdev->dev, "Failed to prepare DMA memcpy\n"); return -EIO;