From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561C7C33CB6 for ; Thu, 16 Jan 2020 23:36:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26D9B2072B for ; Thu, 16 Jan 2020 23:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217816; bh=J2Uu6xeW8tRMtlFYFag5dwkPExafMGRmGM8omqTSyzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Xh05ka85PIbbZMYim39ZE4u8zmmp2WlU2KLEMUXfVsEc2GntjPWVi+N73xuThsu4D dYG7gXOrcvaf0kYT2Nsj8gUK64nDdNWsck+dO4me118qw9snu8mGCRQN0k5pUPLeuJ hXM6qhAYl2gLFilKwGqsO5SHdItJntOcvYYWFdEw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403919AbgAPXb2 (ORCPT ); Thu, 16 Jan 2020 18:31:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:38402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391429AbgAPXay (ORCPT ); Thu, 16 Jan 2020 18:30:54 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9221A20661; Thu, 16 Jan 2020 23:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217454; bh=J2Uu6xeW8tRMtlFYFag5dwkPExafMGRmGM8omqTSyzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LfZ0d9nkjxcW9ehfOB9vN+xsESxoO59ZMaY0weISPar25xQBPD3jTfVO91Mu0yi1x HN+WWWWFjWfRS/DEY3BmDxI2NGG8nlyG1ZEvtOxRLvRKa70MW0K+YucwSPHw94ayra Ax7a1uxaK5jwqi5NNsPG4OSi/1qUiGxAPw4dKBik= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Seung-Woo Kim , Sylwester Nawrocki , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.19 64/84] media: exynos4-is: Fix recursive locking in isp_video_release() Date: Fri, 17 Jan 2020 00:18:38 +0100 Message-Id: <20200116231721.169640544@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Seung-Woo Kim commit 704c6c80fb471d1bb0ef0d61a94617d1d55743cd upstream. >>From isp_video_release(), &isp->video_lock is held and subsequent vb2_fop_release() tries to lock vdev->lock which is same with the previous one. Replace vb2_fop_release() with _vb2_fop_release() to fix the recursive locking. Fixes: 1380f5754cb0 ("[media] videobuf2: Add missing lock held on vb2_fop_release") Signed-off-by: Seung-Woo Kim Reviewed-by: Sylwester Nawrocki Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/exynos4-is/fimc-isp-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/exynos4-is/fimc-isp-video.c +++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c @@ -316,7 +316,7 @@ static int isp_video_release(struct file ivc->streaming = 0; } - vb2_fop_release(file); + _vb2_fop_release(file, NULL); if (v4l2_fh_is_singular_file(file)) { fimc_pipeline_call(&ivc->ve, close);