From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5582CC33CB6 for ; Thu, 16 Jan 2020 23:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18B812072E for ; Thu, 16 Jan 2020 23:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579216686; bh=sRgzjZ104YRB9uSBtj2YBeetB98wSDi6XX2e4P7sNt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HfJciAa4WwKr8NrTm4H8GC/FgpfhtZDJsKHYi606AkRfcvDkfB8D15VpwH4eIrBVD dOQHnxWTh5fm0lbyqAJ/vYf5gQuXDSzlHAVBM5DR0fZJcsRXUBrudgb6s4OWRxPK1U l0SsFmEVrJRvbbQtEE7ElnXTZBlZbJIepVazzmB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389749AbgAPXSE (ORCPT ); Thu, 16 Jan 2020 18:18:04 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:42300 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729300AbgAPXSE (ORCPT ); Thu, 16 Jan 2020 18:18:04 -0500 Received: by mail-oi1-f194.google.com with SMTP id 18so20514355oin.9; Thu, 16 Jan 2020 15:18:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AxYTHo1xbvVXlE9BL422q+BMWDP33NtgDNx+D8mvMAI=; b=O91BqJMeQT3mV6q10+/UUIWBGYsyiwRTXSaQHGeXSy3uoBIy0f2+f4mtV7/iwy9h6O kN16XniGJ2Wh1nYDmLN2ywBZdLRw7vSOeX5Gm8giQk0FU9Hai7YfCTbv6drNXtW7dE31 S/aruiY1VPxC/B8tH/TFw4aOP9m/aT+03MY+FkMF4+YZEiVjC1I9BiVE4vJWWRtlDXfL yvoaZUSk7T+EodgUV6lMP/pFQK8BEL4VVHeOLpmT7J3MqWj02XLbPRcp85ebywYzPOOI ti6dCcdJxVvYMxuL0E/vuMd/bcxjkBfjuNuWELjdngM5hjL6if5Z55CjdeIXa/jB7ieB 4Z8g== X-Gm-Message-State: APjAAAUHLcUUxk5kAX1+gqUdkk7dko+LFs0we4M7DCSJtscw7Nb1jJB+ vsfd6OwaRZ/bJE8XpP/gTw== X-Google-Smtp-Source: APXvYqzZJygX0GSguvTQM81bKzfOop6LBjuapSvKPn1gt2ZgNjWt9VE/fJhIO05KbnfYneSZhP3g+A== X-Received: by 2002:aca:c386:: with SMTP id t128mr1347117oif.32.1579216683166; Thu, 16 Jan 2020 15:18:03 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id e21sm7211797oib.16.2020.01.16.15.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 15:18:02 -0800 (PST) Received: (nullmailer pid 30679 invoked by uid 1000); Thu, 16 Jan 2020 23:18:01 -0000 Date: Thu, 16 Jan 2020 17:18:01 -0600 From: Rob Herring To: Olivier Moysan Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, alsa-devel@alsa-project.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: dt-bindings: stm32: convert spdfirx to json-schema Message-ID: <20200116231801.GA18958@bogus> References: <20200116105244.13485-1-olivier.moysan@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116105244.13485-1-olivier.moysan@st.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 11:52:44AM +0100, Olivier Moysan wrote: > Convert the STM32 SPDIFRX bindings to DT schema format using json-schema. > > Signed-off-by: Olivier Moysan > --- > Changes in v2: > - Add "additionalProperties: false" > - Also change minItems to 2 for dmas property, as both DMAs are required. > --- > .../bindings/sound/st,stm32-spdifrx.txt | 56 ------------- > .../bindings/sound/st,stm32-spdifrx.yaml | 84 +++++++++++++++++++ > 2 files changed, 84 insertions(+), 56 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt > create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-spdifrx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt b/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt > deleted file mode 100644 > index 33826f2459fa..000000000000 > --- a/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.txt > +++ /dev/null > @@ -1,56 +0,0 @@ > -STMicroelectronics STM32 S/PDIF receiver (SPDIFRX). > - > -The SPDIFRX peripheral, is designed to receive an S/PDIF flow compliant with > -IEC-60958 and IEC-61937. > - > -Required properties: > - - compatible: should be "st,stm32h7-spdifrx" > - - reg: cpu DAI IP base address and size > - - clocks: must contain an entry for kclk (used as S/PDIF signal reference) > - - clock-names: must contain "kclk" > - - interrupts: cpu DAI interrupt line > - - dmas: DMA specifiers for audio data DMA and iec control flow DMA > - See STM32 DMA bindings, Documentation/devicetree/bindings/dma/stm32-dma.txt > - - dma-names: two dmas have to be defined, "rx" and "rx-ctrl" > - > -Optional properties: > - - resets: Reference to a reset controller asserting the SPDIFRX > - > -The device node should contain one 'port' child node with one child 'endpoint' > -node, according to the bindings defined in Documentation/devicetree/bindings/ > -graph.txt. > - > -Example: > -spdifrx: spdifrx@40004000 { > - compatible = "st,stm32h7-spdifrx"; > - reg = <0x40004000 0x400>; > - clocks = <&rcc SPDIFRX_CK>; > - clock-names = "kclk"; > - interrupts = <97>; > - dmas = <&dmamux1 2 93 0x400 0x0>, > - <&dmamux1 3 94 0x400 0x0>; > - dma-names = "rx", "rx-ctrl"; > - pinctrl-0 = <&spdifrx_pins>; > - pinctrl-names = "default"; > - > - spdifrx_port: port { > - cpu_endpoint: endpoint { > - remote-endpoint = <&codec_endpoint>; > - }; > - }; > -}; > - > -spdif_in: spdif-in { > - compatible = "linux,spdif-dir"; > - > - codec_port: port { > - codec_endpoint: endpoint { > - remote-endpoint = <&cpu_endpoint>; > - }; > - }; > -}; > - > -soundcard { > - compatible = "audio-graph-card"; > - dais = <&spdifrx_port>; > -}; > diff --git a/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.yaml b/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.yaml > new file mode 100644 > index 000000000000..e19313e7a552 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/st,stm32-spdifrx.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/st,stm32-spdifrx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 S/PDIF receiver (SPDIFRX) > + > +maintainers: > + - Olivier Moysan > + > +description: | > + The SPDIFRX peripheral, is designed to receive an S/PDIF flow compliant with > + IEC-60958 and IEC-61937. > + > +properties: > + compatible: > + enum: > + - st,stm32h7-spdifrx > + > + "#sound-dai-cells": > + const: 0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: kclk > + > + interrupts: > + maxItems: 1 > + > + dmas: > + description: | > + Two DMA channel specifiers are requested: > + - audio data capture DMA > + - IEC status bits capture DMA > + See STM32 DMA bindings /bindings/dma/stm32-dma.txt. > + minItems: 2 > + maxItems: 2 dmas: items: - description: audio data capture DMA - description: IEC status bits capture DMA And minItems/maxItems aren't necessary. I'd probably just drop 'See STM32 DMA bindings /bindings/dma/stm32-dma.txt' too, so we don't have to update this when that file is converted to schema. > + > + dma-names: > + items: > + - const: rx > + - const: rx-ctrl > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - "#sound-dai-cells" > + - reg > + - clocks > + - clock-names > + - interrupts > + - dmas > + - dma-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + spdifrx: spdifrx@40004000 { > + compatible = "st,stm32h7-spdifrx"; > + #sound-dai-cells = <0>; > + reg = <0x40004000 0x400>; > + clocks = <&rcc SPDIF_K>; > + clock-names = "kclk"; > + interrupts = ; > + dmas = <&dmamux1 2 93 0x400 0x0>, > + <&dmamux1 3 94 0x400 0x0>; > + dma-names = "rx", "rx-ctrl"; > + pinctrl-0 = <&spdifrx_pins>; > + pinctrl-names = "default"; > + }; > + > +... > -- > 2.17.1 >