Re: [PATCH] mfd: bd70528: Fix hour register mask

From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"sashal@kernel.org" <sashal@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] mfd: bd70528: Fix hour register mask
Date: Fri, 17 Jan 2020 08:57:14 +0100	[thread overview]
Message-ID: <20200117075714.GA1822218@kroah.com> (raw)
In-Reply-To: <83e8e1ecc40a58e2e6d1960bbb41c8dcfe730ce1.camel@fi.rohmeurope.com>

On Fri, Jan 17, 2020 at 07:44:07AM +0000, Vaittinen, Matti wrote:
> Hello Lee, Alexandre, Greg & Sasha
> 
> On Wed, 2020-01-15 at 10:29 +0200, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > 
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528
> > RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> > 
> > I just noticed this was never applied. I'd like to get this in as
> > we currently have bd70528 RTC not working in few exiting releases.
> > (Or it works as long as time is not set at the evening :/)
> > 
> > I think this once was in RTC tree but was dropped as Lee mentioned
> > this
> > belongs to MFD. Thus I dared to add the Alexandre's acked-by - please
> > let me know if this is not Ok.
> > 
> > Lee, can you please pull this in so that we get the fix
> > in-tree? I guess the fixes tag helps this to be included in some
> > existing branches.
> 
> Actually - I don't know if applying this in MFD is good idea. The
> BD71828 support series
> 
> (
> https://lore.kernel.org/lkml/cover.1579078681.git.matti.vaittinen@fi.rohmeurope.com/
> )
> 
> will fix this when applied (and conflict with this if both are
> applied). I would like to get this fix in 5.4 though - but I don't
> think the BD71828 series should be in 5.4.
> 
> Is it possible to get this in 5.4 stable - while leaving this out of
> current MFD tree and applying the BD71828 series to MFD?

We only take patches that are in Linus's tree for the stable tree,
unless there are very big reasons not to do so (i.e. it is totally
rewritten in a different way there.)

Once the change/fix is in Linus's tree, then you can backport it to
stable in a different way if you want, but you need to give lots of
reasons why it is done that way.

thanks,

greg k-h