From: Greg KH <gregkh@linuxfoundation.org>
To: roman.sudarikov@linux.intel.com
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, eranian@google.com,
bgregg@netflix.com, ak@linux.intel.com,
kan.liang@linux.intel.com, alexander.antonov@intel.com
Subject: Re: [PATCH v4 1/2] perf x86: Infrastructure for exposing an Uncore unit to PMON mapping
Date: Fri, 17 Jan 2020 15:16:12 +0100 [thread overview]
Message-ID: <20200117141612.GB1856891@kroah.com> (raw)
In-Reply-To: <20200117133759.5729-2-roman.sudarikov@linux.intel.com>
On Fri, Jan 17, 2020 at 04:37:58PM +0300, roman.sudarikov@linux.intel.com wrote:
> From: Roman Sudarikov <roman.sudarikov@linux.intel.com>
>
> Intel® Xeon® Scalable processor family (code name Skylake-SP) makes
> significant changes in the integrated I/O (IIO) architecture. The new
> solution introduces IIO stacks which are responsible for managing traffic
> between the PCIe domain and the Mesh domain. Each IIO stack has its own
> PMON block and can handle either DMI port, x16 PCIe root port, MCP-Link
> or various built-in accelerators. IIO PMON blocks allow concurrent
> monitoring of I/O flows up to 4 x4 bifurcation within each IIO stack.
>
> Software is supposed to program required perf counters within each IIO
> stack and gather performance data. The tricky thing here is that IIO PMON
> reports data per IIO stack but users have no idea what IIO stacks are -
> they only know devices which are connected to the platform.
>
> Understanding IIO stack concept to find which IIO stack that particular
> IO device is connected to, or to identify an IIO PMON block to program
> for monitoring specific IIO stack assumes a lot of implicit knowledge
> about given Intel server platform architecture.
>
> Usage example:
> /sys/devices/uncore_<type>_<pmu_idx>/mapping
>
> Each Uncore unit type, by its nature, can be mapped to its own context,
> for example:
> 1. CHA - each uncore_cha_<pmu_idx> is assigned to manage a distinct slice
> of LLC capacity;
> 2. UPI - each uncore_upi_<pmu_idx> is assigned to manage one link of Intel
> UPI Subsystem;
> 3. IIO - each uncore_iio_<pmu_idx> is assigned to manage one stack of the
> IIO module;
> 4. IMC - each uncore_imc_<pmu_idx> is assigned to manage one channel of
> Memory Controller.
>
> Implementation details:
> Two callbacks added to struct intel_uncore_type to discover and map Uncore
> units to PMONs:
> int (*get_topology)(struct intel_uncore_type *type, int max_dies)
> int (*set_mapping)(struct intel_uncore_type *type, int max_dies)
>
> Details of IIO Uncore unit mapping to IIO PMON:
> Each IIO stack is either DMI port, x16 PCIe root port, MCP-Link or various
> built-in accelerators. For Uncore IIO Unit type, the mapping file
> holds bus numbers of devices, which can be monitored by that IIO PMON block
> on each die.
>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> Co-developed-by: Alexander Antonov <alexander.antonov@intel.com>
> Signed-off-by: Alexander Antonov <alexander.antonov@intel.com>
> Signed-off-by: Roman Sudarikov <roman.sudarikov@linux.intel.com>
> ---
> arch/x86/events/intel/uncore.c | 46 ++++++++++++++++++++++++++++++++++
> arch/x86/events/intel/uncore.h | 6 +++++
> 2 files changed, 52 insertions(+)
>
> diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
> index 86467f85c383..55201bfde2c8 100644
> --- a/arch/x86/events/intel/uncore.c
> +++ b/arch/x86/events/intel/uncore.c
> @@ -825,6 +825,44 @@ static const struct attribute_group uncore_pmu_attr_group = {
> .attrs = uncore_pmu_attrs,
> };
>
> +static ssize_t mapping_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct intel_uncore_pmu *pmu = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE - 1, "%s\n", pmu->mapping);
> +}
> +static DEVICE_ATTR_RO(mapping);
> +
> +static struct attribute *mapping_attrs[] = {
> + &dev_attr_mapping.attr,
> + NULL,
> +};
> +
> +static struct attribute_group mapping_group = {
> + .attrs = mapping_attrs,
> +};
> +
> +static umode_t
> +not_visible(struct kobject *kobj, struct attribute *attr, int i)
> +{
> + return 0;
> +}
> +
> +static const struct attribute_group *attr_update[] = {
> + &mapping_group,
> + NULL,
> +};
ATTRIBUTE_GROUPS()?
> +
> +static void uncore_platform_mapping(struct intel_uncore_type *t)
> +{
> + if (t->get_topology && t->set_mapping &&
> + !t->get_topology(t, max_dies) && !t->set_mapping(t, max_dies))
> + mapping_group.is_visible = NULL;
No need to set something to NULL that is already set to NULL, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-17 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 13:37 [PATCH v4 0/2] perf x86: Exposing IO stack to IO PMON mapping through sysfs roman.sudarikov
2020-01-17 13:37 ` [PATCH v4 1/2] perf x86: Infrastructure for exposing an Uncore unit to PMON mapping roman.sudarikov
2020-01-17 14:16 ` Greg KH [this message]
2020-01-17 13:37 ` [PATCH v4 2/2] perf x86: Exposing an Uncore unit to PMON for Intel Xeon® server platform roman.sudarikov
2020-01-17 14:19 ` Greg KH
2020-01-17 16:23 ` Andi Kleen
2020-01-17 16:54 ` Greg KH
2020-01-17 17:27 ` Andi Kleen
2020-01-17 18:42 ` Greg KH
2020-01-17 19:12 ` Andi Kleen
2020-01-17 23:03 ` Greg KH
2020-01-17 23:21 ` Andi Kleen
2020-01-21 16:15 ` Sudarikov, Roman
2020-01-21 17:15 ` Greg KH
2020-01-28 14:55 ` Sudarikov, Roman
2020-01-28 20:19 ` Liang, Kan
2020-01-17 14:14 ` [PATCH v4 0/2] perf x86: Exposing IO stack to IO PMON mapping through sysfs Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117141612.GB1856891@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bgregg@netflix.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=roman.sudarikov@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).