From: kbuild test robot <lkp@intel.com>
To: James Clark <james.clark@arm.com>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
nd@arm.com, James Clark <james.clark@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Tan Xiaojun <tanxiaojun@huawei.com>,
Al Grant <al.grant@arm.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Return EINVAL when precise_ip perf events are requested on Arm
Date: Sat, 18 Jan 2020 22:11:56 +0800 [thread overview]
Message-ID: <202001182239.IJMl4SVW%lkp@intel.com> (raw)
In-Reply-To: <20200115105855.13395-2-james.clark@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2551 bytes --]
Hi James,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm-soc/for-next]
[also build test ERROR on tip/perf/core linux/master linus/master v5.5-rc6 next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/James-Clark/Return-EINVAL-when-precise_ip-perf-events-are-requested-on-Arm/20200116-195500
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//perf/arm_pmu.c: In function 'armpmu_map_event':
>> drivers//perf/arm_pmu.c:105:18: error: 'struct perf_event_attr' has no member named 'precise'; did you mean 'precise_ip'?
if (event->attr.precise)
^~~~~~~
precise_ip
vim +105 drivers//perf/arm_pmu.c
92
93 int
94 armpmu_map_event(struct perf_event *event,
95 const unsigned (*event_map)[PERF_COUNT_HW_MAX],
96 const unsigned (*cache_map)
97 [PERF_COUNT_HW_CACHE_MAX]
98 [PERF_COUNT_HW_CACHE_OP_MAX]
99 [PERF_COUNT_HW_CACHE_RESULT_MAX],
100 u32 raw_event_mask)
101 {
102 u64 config = event->attr.config;
103 int type = event->attr.type;
104
> 105 if (event->attr.precise)
106 return -EINVAL;
107
108 if (type == event->pmu->type)
109 return armpmu_map_raw_event(raw_event_mask, config);
110
111 switch (type) {
112 case PERF_TYPE_HARDWARE:
113 return armpmu_map_hw_event(event_map, config);
114 case PERF_TYPE_HW_CACHE:
115 return armpmu_map_cache_event(cache_map, config);
116 case PERF_TYPE_RAW:
117 return armpmu_map_raw_event(raw_event_mask, config);
118 }
119
120 return -ENOENT;
121 }
122
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72712 bytes --]
prev parent reply other threads:[~2020-01-18 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 10:58 [PATCH 0/1] Return EINVAL when precise_ip perf events are requested on Arm James Clark
2020-01-15 10:58 ` [PATCH 1/1] " James Clark
2020-01-17 12:39 ` Will Deacon
2020-01-17 13:05 ` Will Deacon
2020-01-17 13:11 ` James Clark
2020-01-17 14:01 ` Peter Zijlstra
2020-01-17 15:00 ` James Clark
2020-01-17 15:16 ` Peter Zijlstra
2020-01-20 15:33 ` Mark Rutland
2020-01-18 14:11 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001182239.IJMl4SVW%lkp@intel.com \
--to=lkp@intel.com \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=tanxiaojun@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).