From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, yang.shi@linux.alibaba.com,
jhubbard@nvidia.com, vbabka@suse.cz, cl@linux.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [Patch v2] mm/migrate.c: also overwrite error when it is bigger than zero
Date: Sun, 19 Jan 2020 14:57:53 +0800 [thread overview]
Message-ID: <20200119065753.21694-1-richardw.yang@linux.intel.com> (raw)
If we get here after successfully adding page to list, err would be
1 to indicate the page is queued in the list.
Current code has two problems:
* on success, 0 is not returned
* on error, if add_page_for_migratioin() return 1, and the following err1
from do_move_pages_to_node() is set, the err1 is not returned since err
is 1
And these behaviors break the user interface.
Fixes: e0153fc2c760 ("mm: move_pages: return valid node id in status if the
page is already on the target node").
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
v2:
* put more words to explain the error case
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 86873b6f38a7..430fdccc733e 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1676,7 +1676,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
err1 = do_move_pages_to_node(mm, &pagelist, current_node);
if (!err1)
err1 = store_status(status, start, current_node, i - start);
- if (!err)
+ if (err >= 0)
err = err1;
out:
return err;
--
2.17.1
next reply other threads:[~2020-01-19 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 6:57 Wei Yang [this message]
2020-01-21 1:53 ` [Patch v2] mm/migrate.c: also overwrite error when it is bigger than zero Wei Yang
2020-01-21 2:34 ` Wei Yang
2020-01-21 19:33 ` John Hubbard
2020-01-22 0:42 ` Wei Yang
2020-01-22 1:29 ` John Hubbard
2020-01-21 19:30 ` Yang Shi
2020-01-22 0:41 ` Wei Yang
2020-01-24 7:21 ` Michal Hocko
2020-01-24 14:15 ` Wei Yang
2020-01-24 14:46 ` Michal Hocko
2020-01-24 15:28 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119065753.21694-1-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).