From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16B8C33CA1 for ; Mon, 20 Jan 2020 12:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98273208E4 for ; Mon, 20 Jan 2020 12:17:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q8jJfz8k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728205AbgATMRj (ORCPT ); Mon, 20 Jan 2020 07:17:39 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:59869 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726589AbgATMRj (ORCPT ); Mon, 20 Jan 2020 07:17:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579522657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8L+ILVTS7iEVpEf9FQ7Niyp0BU3VQIiebmcN8SzOcl8=; b=Q8jJfz8kyQyUMTq+IqvBSU4xbhlSH9LCcDAIZk5+hsFJTxy9yMXVXtc0X/wvSkx+ykf66Q ttNo9gVr8SXSpg3wS/nySmKhQEqoIUSAVzraxC/kXD8JBTvYO2H/vDUGf32YfZJhNU2vRM uXaJUloQwg1Pf7GxPEsxVZJDV9WTUDs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-544L1SHHN4WVFB8JeveWfg-1; Mon, 20 Jan 2020 07:17:36 -0500 X-MC-Unique: 544L1SHHN4WVFB8JeveWfg-1 Received: by mail-qv1-f70.google.com with SMTP id u11so20545565qvo.8 for ; Mon, 20 Jan 2020 04:17:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8L+ILVTS7iEVpEf9FQ7Niyp0BU3VQIiebmcN8SzOcl8=; b=Md6ZcYMskVYHDJQzYEcLKZtEGZxinwpjSa6F7bfAvZwyLXbXqbc0OE/BJLRgwSamKE GfZ4EQSzYDltznTgY1J2ZpVc0Wq0nhY3DLG5zf8k0zkxMw8jYb1iPP+7MQoZJirA700Z N3EeH06N6hw6Ut08ZI+w0u+qwfRmALgNv+/OkALhRFckBPJI1jG5l4pHHTFjGTDClTGW 1dUZgzuy4YBM+q46OltuaAJBbfzZbGLNfaAnmq0ZepwvXEag3BeBg7Pog/WG0kj0vB92 SEqiBzhvzr1xrbbwHShOGlrlrBJRbybqiVL1UffuumcC1GguNSwlzBbA0ivqTp0mXdSP /Ysw== X-Gm-Message-State: APjAAAXnfePKN8s4EmDA+pURp1Yby7cSQle7fmXMfemVQy+urRGh9lrr +9fh1XVocdXOJ+cH/MaKqDvY/xfDhvcdCscBsRu0KolYBrZ4yPognrlmOcZqen0MxtAxZvgnM+J c3q7AcdxkkLql6UZEGimaPMF7 X-Received: by 2002:ac8:784:: with SMTP id l4mr19850124qth.286.1579522656241; Mon, 20 Jan 2020 04:17:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwNA60FKJeMn0/BVl0tQjIyzqQrUvdMi0GrHZyiN0uIGAcUXWQkWAFroQqD7gDCIK6n3lBLSQ== X-Received: by 2002:ac8:784:: with SMTP id l4mr19850095qth.286.1579522655996; Mon, 20 Jan 2020 04:17:35 -0800 (PST) Received: from redhat.com (bzq-79-179-85-180.red.bezeqint.net. [79.179.85.180]) by smtp.gmail.com with ESMTPSA id y26sm17884235qtc.94.2020.01.20.04.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 04:17:34 -0800 (PST) Date: Mon, 20 Jan 2020 07:17:26 -0500 From: "Michael S. Tsirkin" To: Jason Gunthorpe Cc: Jason Wang , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "tiwei.bie@intel.com" , "maxime.coquelin@redhat.com" , "cunming.liang@intel.com" , "zhihong.wang@intel.com" , "rob.miller@broadcom.com" , "xiao.w.wang@intel.com" , "haotian.wang@sifive.com" , "lingshan.zhu@intel.com" , "eperezma@redhat.com" , "lulu@redhat.com" , Parav Pandit , "kevin.tian@intel.com" , "stefanha@redhat.com" , "rdunlap@infradead.org" , "hch@infradead.org" , "aadam@redhat.com" , "jakub.kicinski@netronome.com" , Jiri Pirko , Shahaf Shuler , "hanand@xilinx.com" , "mhabets@solarflare.com" Subject: Re: [PATCH 3/5] vDPA: introduce vDPA bus Message-ID: <20200120071406-mutt-send-email-mst@kernel.org> References: <20200116124231.20253-1-jasowang@redhat.com> <20200116124231.20253-4-jasowang@redhat.com> <20200116152209.GH20978@mellanox.com> <03cfbcc2-fef0-c9d8-0b08-798b2a293b8c@redhat.com> <20200117135435.GU20978@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117135435.GU20978@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2020 at 01:54:42PM +0000, Jason Gunthorpe wrote: > > 1) "virtio" vs "vhost", I implemented matching method for this in mdev > > series, but it looks unnecessary for vDPA device driver to know about this. > > Anyway we can use sysfs driver bind/unbind to switch drivers > > 2) virtio device id and vendor id. I'm not sure we need this consider the > > two drivers so far (virtio/vhost) are all bus drivers. > > As we seem to be contemplating some dynamic creation of vdpa devices I > think upon creation time it should be specified what mode they should > run it and then all driver binding and autoloading should happen > automatically. Telling the user to bind/unbind is a very poor > experience. Maybe but OTOH it's an existing interface. I think we can reasonably start with bind/unbind and then add ability to specify the mode later. bind/unbind come from core so they will be maintained anyway. -- MST