From: Michal Hocko <mhocko@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Leonardo Bras <leonardo@linux.ibm.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
Allison Randal <allison@lohutok.net>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Anshuman Khandual <anshuman.khandual@arm.com>,
lantianyu1986@gmail.com,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH RFC v1] mm: is_mem_section_removable() overhaul
Date: Mon, 20 Jan 2020 08:48:16 +0100 [thread overview]
Message-ID: <20200120074816.GG18451@dhcp22.suse.cz> (raw)
In-Reply-To: <CAPcyv4jvmYRbX9i+1_LvHoTDGABadHbYH3NVkqczKsQ4fsf74g@mail.gmail.com>
On Fri 17-01-20 08:57:51, Dan Williams wrote:
[...]
> Unless the user is willing to hold the device_hotplug_lock over the
> evaluation then the result is unreliable.
Do we want to hold the device_hotplug_lock from this user readable file
in the first place? My book says that this just waits to become a
problem.
Really, the interface is flawed and should have never been merged in the
first place. We cannot simply remove it altogether I am afraid so let's
at least remove the bogus code and pretend that the world is a better
place where everything is removable except the reality sucks...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-20 7:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 10:57 [PATCH RFC v1] mm: is_mem_section_removable() overhaul David Hildenbrand
2020-01-17 11:33 ` Michal Hocko
2020-01-17 13:08 ` David Hildenbrand
2020-01-17 14:52 ` Michal Hocko
2020-01-17 14:58 ` David Hildenbrand
2020-01-17 15:29 ` Michal Hocko
2020-01-17 15:54 ` Dan Williams
2020-01-17 16:10 ` David Hildenbrand
2020-01-17 16:57 ` Dan Williams
2020-01-20 7:48 ` Michal Hocko [this message]
2020-01-20 9:14 ` David Hildenbrand
2020-01-20 9:20 ` David Hildenbrand
2020-01-21 12:07 ` Michal Hocko
2020-01-22 10:39 ` David Hildenbrand
2020-01-22 10:42 ` Michal Hocko
2020-01-22 10:54 ` David Hildenbrand
2020-01-22 11:58 ` David Hildenbrand
2020-01-22 16:46 ` Michal Hocko
2020-01-22 18:15 ` David Hildenbrand
2020-01-22 18:38 ` Michal Hocko
2020-01-22 18:46 ` David Hildenbrand
2020-01-22 19:09 ` Michal Hocko
2020-01-22 20:51 ` Dan Williams
2020-01-22 19:01 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120074816.GG18451@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=anshuman.khandual@arm.com \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=lantianyu1986@gmail.com \
--cc=leonardo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=rafael@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).