From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2662C2D0DB for ; Mon, 20 Jan 2020 11:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7686620882 for ; Mon, 20 Jan 2020 11:14:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PU4f5YGv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgATLOh (ORCPT ); Mon, 20 Jan 2020 06:14:37 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41191 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbgATLOh (ORCPT ); Mon, 20 Jan 2020 06:14:37 -0500 Received: by mail-wr1-f65.google.com with SMTP id c9so29106474wrw.8 for ; Mon, 20 Jan 2020 03:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=MLTZFPkjIVTzjTUJPG0GQ7JUAyMN3WoGalm3BKLJ7uU=; b=PU4f5YGvwhz9nKHkxC9h0SOSEtjVAayEf3i28kxO+eSOizCINzkqdUBipr/DlZ+Tat z+H1ny4xJDEr7U4BMT66LsDt95kihsc8Lzkjd9euZ7aucT/10xyQ/HgiAEmqPB9Wi4zN fV+fUEMJ+G+oeA5coQUKM5dY0AT8qZcOEaIejUw1B5gCA8OCzAn4KAQ1YLRmYzcN9/4r q55sf6Aes/LjqXvbFLqzV7ap8oEXfHhzEerWGT4n+ae1m5pMZJnRUOHvLjm3JeKhP51b XaAJxSO2o2mt+IPrjzAEc2XfHRRN84Ql645KlEG4PiW/DRdKqJUrDekrGc7o09fR8CTh zCAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=MLTZFPkjIVTzjTUJPG0GQ7JUAyMN3WoGalm3BKLJ7uU=; b=ndkKNJwjuY6AOnktGVSkyaNZpF/UwFtEu//4jMRVZ3Hk3EyLY4GhBfGrkgEqA/0dER MNtjqQOJCpLHaQIkGiAPGCkl92+yqtB10VwFH4iF81a8vySVgask3FH5PPhCAEd9GDtj XtB5XLL0J6r+4O9JWF3UAKeA2qjySDhvtdWcN+1qMsqsP0xu5Kt+E6GgQVov3mYu0/Oe xxfZzPxzkW5fGtlbzDvWyvlbZ2Q2FR9DYaifDHYLGpaNaMKT+8QRrkBJICVIrItHBwZK zZP6r6S8XC75+B5feO327Cp8uOGPpN6qkPJe9alkkh8jJJ7RSI1vECcOgeupaLWyhRwN wNDg== X-Gm-Message-State: APjAAAXYk6O919wd0yJbr8eYHNGVau+bTegTEPFoIurXzLtAp5v9V002 rBHaYiX9AFqedp/j4p9agjQaNw== X-Google-Smtp-Source: APXvYqytziXSBvUudozXjrvT1+OyixIcrmWxfebeA0//fm/82uAbuWMv0hmjSOZymA7vF9JeJ01GNA== X-Received: by 2002:a5d:49c7:: with SMTP id t7mr17246479wrs.369.1579518875038; Mon, 20 Jan 2020 03:14:35 -0800 (PST) Received: from dell ([2.27.35.227]) by smtp.gmail.com with ESMTPSA id j12sm47914128wrt.55.2020.01.20.03.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 03:14:34 -0800 (PST) Date: Mon, 20 Jan 2020 11:14:50 +0000 From: Lee Jones To: Mika Westerberg Cc: Andy Shevchenko , Darren Hart , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 35/36] platform/x86: intel_pmc_ipc: Convert to MFD Message-ID: <20200120111450.GE15507@dell> References: <20200113135623.56286-1-mika.westerberg@linux.intel.com> <20200113135623.56286-36-mika.westerberg@linux.intel.com> <20200116132108.GH325@dell> <20200116143730.GE2838@lahna.fi.intel.com> <20200117113202.GH15507@dell> <20200117142750.GP2838@lahna.fi.intel.com> <20200120081246.GS15507@dell> <20200120091258.GH2665@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200120091258.GH2665@lahna.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jan 2020, Mika Westerberg wrote: > On Mon, Jan 20, 2020 at 08:12:46AM +0000, Lee Jones wrote: > > > Well, by "library" I mean that the SCU IPC itself does not bind to > > > anything but instead it gets called by different drivers such as this > > > one passing the device pointer that is the SCU IPC device. Here for > > > example it is the platfrom device created from an ACPI description. > > > > Not keen on that at all. Why can it not be a platform device? > > We also call the same library from a PCI driver (intel_scu_pcidrv.c in > this series) where the device is of type struct pci_dev. Not sure I understand the issue. What does the device do? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog