From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C357CC33CAA for ; Tue, 21 Jan 2020 08:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90CAA21734 for ; Tue, 21 Jan 2020 08:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YSlJP+Ou" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728139AbgAUIP6 (ORCPT ); Tue, 21 Jan 2020 03:15:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27063 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725890AbgAUIP5 (ORCPT ); Tue, 21 Jan 2020 03:15:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579594555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LDZZx/Gnj5ZRM82WjxYSmYyaFueti+mk2d2ohpv+jeI=; b=YSlJP+OuHEsfvx0Qe2cYsmzBSL9sRbJbG8j7AbIn0+2OeG0juRr6le7jYZxtUzeiJy8HHd eg3dC25id+/aPD4QYhaa8CibBHkMpDfOUD3cuXPbNR1uY6Z22bgboDlzByLy4qq4KL+LOI g6y84rSSPPqNypEbuTwxt8lTiMDSF6o= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-I2I5HWkwPueoJdmkX5RYng-1; Tue, 21 Jan 2020 03:15:54 -0500 X-MC-Unique: I2I5HWkwPueoJdmkX5RYng-1 Received: by mail-qv1-f71.google.com with SMTP id f16so1110744qvr.7 for ; Tue, 21 Jan 2020 00:15:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LDZZx/Gnj5ZRM82WjxYSmYyaFueti+mk2d2ohpv+jeI=; b=FTn4MynfR80Dn9kcYRHRheuSo4ulWm4T+VF3C7SBhxGmrFb7fiGyhesyS6cGNCLwgM iycnkbruuqX3Oni6ML81xFRE7eaV2OQ5QlAe7PZs1K/mfNG5MdRvBjTlyC4piMBFk1sQ S79pv7B1M7R6ognpOBEy64HKIahJigMUQueD8frE86PYrMcgy2Gpo2V/YV0n8bPNT0dl f62GMPibmdlVlF9s81XGArjIbQHEf8wUWBIKXiteKsHEAdh25wUouyB2sr6/ite0JTmk qJOo9XKEuqPIl0Zpxdz8EowNjLqShOjkLNY6z27xnxwUPCu3DS2cUI+MRMWzh/8C7p1V kEwA== X-Gm-Message-State: APjAAAV1rKkRz0xjZMWO/Z4j+aiLO6qqU+DDyMll7+cNJ9L2djtf0ymW NC8bchVG0zNXByUnlulxI6UAGFb5BnVoknzm9K7zzuAq8OjKFFm028xsUoqJIGGIBMNFU9hjFnv eXlTsJ7iKKZXi4yMuyR5OplMR X-Received: by 2002:a37:4792:: with SMTP id u140mr3527888qka.100.1579594553677; Tue, 21 Jan 2020 00:15:53 -0800 (PST) X-Google-Smtp-Source: APXvYqxdkjBVx/UGOKVK94Xs4SyAvooIxcojAHiVS5/OG5oUdaH/4DoRhuXXCGIK/jBUqS0IK043lw== X-Received: by 2002:a37:4792:: with SMTP id u140mr3527856qka.100.1579594553353; Tue, 21 Jan 2020 00:15:53 -0800 (PST) Received: from redhat.com (bzq-79-179-85-180.red.bezeqint.net. [79.179.85.180]) by smtp.gmail.com with ESMTPSA id z3sm18825316qtm.5.2020.01.21.00.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 00:15:52 -0800 (PST) Date: Tue, 21 Jan 2020 03:15:43 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Jason Gunthorpe , Shahaf Shuler , Rob Miller , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Netdev , "Bie, Tiwei" , "maxime.coquelin@redhat.com" , "Liang, Cunming" , "Wang, Zhihong" , "Wang, Xiao W" , "haotian.wang@sifive.com" , "Zhu, Lingshan" , "eperezma@redhat.com" , "lulu@redhat.com" , Parav Pandit , "Tian, Kevin" , "stefanha@redhat.com" , "rdunlap@infradead.org" , "hch@infradead.org" , Ariel Adam , "jakub.kicinski@netronome.com" , Jiri Pirko , "hanand@xilinx.com" , "mhabets@solarflare.com" Subject: Re: [PATCH 3/5] vDPA: introduce vDPA bus Message-ID: <20200121031506-mutt-send-email-mst@kernel.org> References: <20200116124231.20253-4-jasowang@redhat.com> <20200117070324-mutt-send-email-mst@kernel.org> <239b042c-2d9e-0eec-a1ef-b03b7e2c5419@redhat.com> <20200120174933.GB3891@mellanox.com> <2a324cec-2863-58f4-c58a-2414ee32c930@redhat.com> <20200121004047-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:00:38PM +0800, Jason Wang wrote: > > On 2020/1/21 下午1:47, Michael S. Tsirkin wrote: > > On Tue, Jan 21, 2020 at 12:00:57PM +0800, Jason Wang wrote: > > > On 2020/1/21 上午1:49, Jason Gunthorpe wrote: > > > > On Mon, Jan 20, 2020 at 04:43:53PM +0800, Jason Wang wrote: > > > > > This is similar to the design of platform IOMMU part of vhost-vdpa. We > > > > > decide to send diffs to platform IOMMU there. If it's ok to do that in > > > > > driver, we can replace set_map with incremental API like map()/unmap(). > > > > > > > > > > Then driver need to maintain rbtree itself. > > > > I think we really need to see two modes, one where there is a fixed > > > > translation without dynamic vIOMMU driven changes and one that > > > > supports vIOMMU. > > > > > > I think in this case, you meant the method proposed by Shahaf that sends > > > diffs of "fixed translation" to device? > > > > > > It would be kind of tricky to deal with the following case for example: > > > > > > old map [4G, 16G) new map [4G, 8G) > > > > > > If we do > > > > > > 1) flush [4G, 16G) > > > 2) add [4G, 8G) > > > > > > There could be a window between 1) and 2). > > > > > > It requires the IOMMU that can do > > > > > > 1) remove [8G, 16G) > > > 2) flush [8G, 16G) > > > 3) change [4G, 8G) > > > > > > .... > > Basically what I had in mind is something like qemu memory api > > > > 0. begin > > 1. remove [8G, 16G) > > 2. add [4G, 8G) > > 3. commit > > > This sounds more flexible e.g driver may choose to implement static mapping > one through commit. But a question here, it looks to me this still requires > the DMA to be synced with at least commit here. Otherwise device may get DMA > fault? Or device is expected to be paused DMA during begin? > > Thanks For example, commit might switch one set of tables for another, without need to pause DMA. > > > > > Anyway, I'm fine with a one-shot API for now, we can > > improve it later. > > > > > > There are different optimization goals in the drivers for these two > > > > configurations. > > > > > > > > > > If the first one, then I think memory hotplug is a heavy flow > > > > > > regardless. Do you think the extra cycles for the tree traverse > > > > > > will be visible in any way? > > > > > I think if the driver can pause the DMA during the time for setting up new > > > > > mapping, it should be fine. > > > > This is very tricky for any driver if the mapping change hits the > > > > virtio rings. :( > > > > > > > > Even a IOMMU using driver is going to have problems with that.. > > > > > > > > Jason > > > > > > Or I wonder whether ATS/PRI can help here. E.g during I/O page fault, > > > driver/device can wait for the new mapping to be set and then replay the > > > DMA. > > > > > > Thanks > > > > >