From: Michal Hocko <mhocko@kernel.org>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com
Subject: Re: [PATCH 7/8] mm/migrate.c: move page on next iteration
Date: Tue, 21 Jan 2020 09:43:52 +0100 [thread overview]
Message-ID: <20200121084352.GE29276@dhcp22.suse.cz> (raw)
In-Reply-To: <20200121012200.GA1567@richard>
On Tue 21-01-20 09:22:00, Wei Yang wrote:
> On Mon, Jan 20, 2020 at 11:02:03AM +0100, Michal Hocko wrote:
> >On Sun 19-01-20 11:06:35, Wei Yang wrote:
> >> When page is not successfully queued for migration, we would move pages
> >> on pagelist immediately. Actually, this could be done in the next
> >> iteration by telling it we need some help.
> >>
> >> This patch adds a new variable need_move to be an indication. After
> >> this, we only need to call move_pages_and_store_status() twice.
> >
> >No! Not another iterator. There are two and this makes the function
> >quite hard to follow already. We do not want to add a third one.
> >
>
> Two iterators here are? I don't get your point.
i is the main iterator to process the whole imput. start is another one
to control the batch to migrate. We do not need/want more. More clear?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-21 8:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 3:06 [PATCH 0/8] mm/migrate.c: cleanup on do_pages_move() Wei Yang
2020-01-19 3:06 ` [PATCH 1/8] mm/migrate.c: skip node check if done in last round Wei Yang
2020-01-20 9:36 ` Michal Hocko
2020-01-20 22:25 ` Wei Yang
2020-01-21 8:42 ` Michal Hocko
2020-01-22 0:36 ` Wei Yang
2020-01-22 8:16 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 2/8] mm/migrate.c: not necessary to check start and i Wei Yang
2020-01-19 22:14 ` David Rientjes
2020-01-20 0:31 ` Wei Yang
2020-01-20 9:45 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 3/8] mm/migrate.c: reform the last call on do_move_pages_to_node() Wei Yang
2020-01-20 9:46 ` Michal Hocko
2020-01-20 22:27 ` Wei Yang
2020-01-19 3:06 ` [PATCH 4/8] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-01-20 9:49 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 5/8] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-01-20 9:52 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 6/8] mm/migrate.c: handle same node and add failure in the same way Wei Yang
2020-01-20 10:01 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 7/8] mm/migrate.c: move page on next iteration Wei Yang
2020-01-20 10:02 ` Michal Hocko
2020-01-21 1:22 ` Wei Yang
2020-01-21 8:43 ` Michal Hocko [this message]
2020-01-22 0:40 ` Wei Yang
2020-01-22 8:17 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 8/8] mm/migrate.c: use break instead of goto out_flush Wei Yang
2020-01-20 10:03 ` Michal Hocko
2020-01-21 1:22 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121084352.GE29276@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).