From: Steven Rostedt <rostedt@goodmis.org>
To: lukasz.luba@arm.com
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-imx@nxp.com,
Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com,
Chris.Redpath@arm.com, ionela.voinescu@arm.com,
javi.merino@arm.com, cw00.choi@samsung.com,
b.zolnierkie@samsung.com, rjw@rjwysocki.net,
sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com,
sboyd@kernel.org, rui.zhang@intel.com,
amit.kucheria@verdurent.com, daniel.lezcano@linaro.org,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, qperret@google.com,
bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com,
kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, robh@kernel.org,
matthias.bgg@gmail.com, steven.price@arm.com,
tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com,
airlied@linux.ie, daniel@ffwll.ch, patrick.bellasi@matbug.net
Subject: Re: [PATCH 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model
Date: Tue, 21 Jan 2020 12:11:24 -0500 [thread overview]
Message-ID: <20200121121124.1a1f3175@gandalf.local.home> (raw)
In-Reply-To: <20200116152032.11301-4-lukasz.luba@arm.com>
On Thu, 16 Jan 2020 15:20:31 +0000
lukasz.luba@arm.com wrote:
> diff --git a/include/trace/events/thermal.h b/include/trace/events/thermal.h
> index 135e5421f003..8a5f04888abd 100644
> --- a/include/trace/events/thermal.h
> +++ b/include/trace/events/thermal.h
> @@ -153,31 +153,30 @@ TRACE_EVENT(thermal_power_cpu_limit,
> TRACE_EVENT(thermal_power_devfreq_get_power,
> TP_PROTO(struct thermal_cooling_device *cdev,
> struct devfreq_dev_status *status, unsigned long freq,
> - u32 dynamic_power, u32 static_power, u32 power),
> + u32 power),
>
> - TP_ARGS(cdev, status, freq, dynamic_power, static_power, power),
> + TP_ARGS(cdev, status, freq, power),
>
> TP_STRUCT__entry(
> __string(type, cdev->type )
> __field(unsigned long, freq )
> - __field(u32, load )
> - __field(u32, dynamic_power )
> - __field(u32, static_power )
> + __field(u32, busy_time)
> + __field(u32, total_time)
> __field(u32, power)
> ),
>
> TP_fast_assign(
> __assign_str(type, cdev->type);
> __entry->freq = freq;
> - __entry->load = (100 * status->busy_time) / status->total_time;
> - __entry->dynamic_power = dynamic_power;
> - __entry->static_power = static_power;
> + __entry->busy_time = status->busy_time;
> + __entry->total_time = status->total_time;
> __entry->power = power;
> ),
>
> - TP_printk("type=%s freq=%lu load=%u dynamic_power=%u static_power=%u power=%u",
> + TP_printk("type=%s freq=%lu load=%u power=%u",
> __get_str(type), __entry->freq,
> - __entry->load, __entry->dynamic_power, __entry->static_power,
> + __entry->total_time == 0 ? 0 :
> + (100 * __entry->busy_time) / __entry->total_time,
> __entry->power)
> );
>
Tracing updates look fine to me. Having the division on the output
makes more sense.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> # for tracing code
-- Steve
next prev parent reply other threads:[~2020-01-21 17:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 15:20 [PATCH 0/4] Add support for devices in the Energy Model lukasz.luba
2020-01-16 15:20 ` [PATCH 1/4] PM / EM: and devices to " lukasz.luba
2020-01-17 10:54 ` Quentin Perret
2020-01-20 14:52 ` Lukasz Luba
2020-01-20 15:09 ` Quentin Perret
2020-01-20 18:27 ` Dietmar Eggemann
2020-01-20 18:38 ` Lukasz Luba
2020-01-21 9:10 ` Dietmar Eggemann
2020-01-21 9:37 ` Quentin Perret
2020-01-21 9:31 ` Quentin Perret
2020-01-20 14:53 ` Dietmar Eggemann
2020-01-20 15:11 ` Dietmar Eggemann
2020-01-20 15:36 ` Lukasz Luba
2020-01-20 15:27 ` Lukasz Luba
2020-01-20 15:28 ` Quentin Perret
2020-01-20 16:20 ` Lukasz Luba
2020-01-21 10:08 ` Quentin Perret
2020-01-21 10:49 ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 2/4] OPP: change parameter to device pointer in dev_pm_opp_of_register_em() lukasz.luba
2020-01-16 15:20 ` [PATCH 3/4] thermal: devfreq_cooling: Refactor code and switch to use Energy Model lukasz.luba
2020-01-21 17:11 ` Steven Rostedt [this message]
2020-01-22 9:35 ` Lukasz Luba
2020-01-16 15:20 ` [PATCH 4/4] drm/panfrost: Register to the Energy Model with devfreq device lukasz.luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121121124.1a1f3175@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Chris.Redpath@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=bsegall@google.com \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nm@ti.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).