From: Chen Zhou <chenzhou10@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<David1.Zhou@amd.com>, <airlied@linux.ie>, <daniel@ffwll.ch>
Cc: <tao.zhou1@amd.com>, <Hawking.Zhang@amd.com>,
<Felix.Kuehling@amd.com>, <amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<chenzhou10@huawei.com>
Subject: [PATCH -next 11/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_device.c
Date: Tue, 21 Jan 2020 21:55:37 +0800 [thread overview]
Message-ID: <20200121135540.165798-12-chenzhou10@huawei.com> (raw)
In-Reply-To: <20200121135540.165798-1-chenzhou10@huawei.com>
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2883:68-73: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 1f0e6b9..29b54d4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -986,7 +986,7 @@ static void amdgpu_device_check_vm_size(struct amdgpu_device *adev)
static void amdgpu_device_check_smu_prv_buffer_size(struct amdgpu_device *adev)
{
struct sysinfo si;
- bool is_os_64 = (sizeof(void *) == 8) ? true : false;
+ bool is_os_64 = sizeof(void *) == 8;
uint64_t total_memory;
uint64_t dram_size_seven_GB = 0x1B8000000;
uint64_t dram_size_three_GB = 0xB8000000;
@@ -2881,7 +2881,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
INIT_WORK(&adev->xgmi_reset_work, amdgpu_device_xgmi_reset_func);
adev->gfx.gfx_off_req_count = 1;
- adev->pm.ac_power = power_supply_is_system_supplied() > 0 ? true : false;
+ adev->pm.ac_power = power_supply_is_system_supplied() > 0;
/* Registers mapping */
/* TODO: block userspace mapping of io register */
@@ -3999,9 +3999,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
struct amdgpu_device *tmp_adev = NULL;
int i, r = 0;
bool in_ras_intr = amdgpu_ras_intr_triggered();
- bool use_baco =
- (amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO) ?
- true : false;
+ bool use_baco = amdgpu_asic_reset_method(adev) == AMD_RESET_METHOD_BACO;
/*
* Flush RAM to disk so that after reboot
--
2.7.4
next prev parent reply other threads:[~2020-01-21 14:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:55 [PATCH -next 00/14] drm/amdgpu: remove unnecessary conversion to bool Chen Zhou
2020-01-21 13:55 ` [PATCH -next 01/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 02/14] drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 03/14] drm/amdgpu: remove unnecessary conversion to bool in navi10_ih.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 04/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v10_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 05/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v5_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 06/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v1_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 07/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_acp.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 08/14] drm/amdgpu: remove unnecessary conversion to bool in soc15.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 09/14] drm/amdgpu: remove unnecessary conversion to bool in nv.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 10/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v9_4.c Chen Zhou
2020-01-21 13:55 ` Chen Zhou [this message]
2020-01-21 13:55 ` [PATCH -next 12/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v2_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 13/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v4_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 14/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v9_0.c Chen Zhou
2020-01-22 20:21 ` [PATCH -next 00/14] drm/amdgpu: remove unnecessary conversion to bool Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121135540.165798-12-chenzhou10@huawei.com \
--to=chenzhou10@huawei.com \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).