From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_RHS_DOB,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1651EC2D0CE for ; Tue, 21 Jan 2020 13:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DABE921569 for ; Tue, 21 Jan 2020 13:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728998AbgAUN7L convert rfc822-to-8bit (ORCPT ); Tue, 21 Jan 2020 08:59:11 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:48531 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbgAUN7K (ORCPT ); Tue, 21 Jan 2020 08:59:10 -0500 X-Originating-IP: 90.76.211.102 Received: from xps13 (lfbn-tou-1-1151-102.w90-76.abo.wanadoo.fr [90.76.211.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B446B60016; Tue, 21 Jan 2020 13:59:08 +0000 (UTC) Date: Tue, 21 Jan 2020 14:59:07 +0100 From: Miquel Raynal To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, christoph.muellner@theobroma-systems.com, Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports Message-ID: <20200121145907.7fef0316@xps13> In-Reply-To: <20200121134510.3893487-1-heiko@sntech.de> References: <20200121134510.3893487-1-heiko@sntech.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, Heiko Stuebner wrote on Tue, 21 Jan 2020 14:45:10 +0100: > From: Heiko Stuebner > > The lvds controller has two ports. port@0 for the connection > to the display controller(s) and port@1 for the connection to > the panel, so should have a ports node covering the port@x nodes. > > Signed-off-by: Heiko Stuebner > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 9b1c92132007..37e014444214 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -421,19 +421,24 @@ lvds: lvds { > rockchip,output = "lvds"; > status = "disabled"; > > - port@0 { > - reg = <0>; > + ports { > #address-cells = <1>; > #size-cells = <0>; > > - lvds_vopb_in: endpoint@0 { > + port@0 { > reg = <0>; > - remote-endpoint = <&vopb_out_lvds>; > - }; > - > - lvds_vopl_in: endpoint@1 { > - reg = <1>; > - remote-endpoint = <&vopl_out_lvds>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + lvds_vopb_in: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vopb_out_lvds>; > + }; > + > + lvds_vopl_in: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&vopl_out_lvds>; > + }; > }; > }; > }; I don't know the exact rule but this seems cleaner indeed. Reviewed-by: Miquel Raynal Thanks, Miquèl