From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4340C2D0CE for ; Tue, 21 Jan 2020 16:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1173206A2 for ; Tue, 21 Jan 2020 16:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729402AbgAUQXd (ORCPT ); Tue, 21 Jan 2020 11:23:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:56562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728916AbgAUQXc (ORCPT ); Tue, 21 Jan 2020 11:23:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6D21EAFE8; Tue, 21 Jan 2020 16:23:30 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1201F1E0A4E; Tue, 21 Jan 2020 17:23:29 +0100 (CET) Date: Tue, 21 Jan 2020 17:23:29 +0100 From: Jan Kara To: Alex Shi Cc: Andrew Morton , Jan Kara , Bharath Vedartham , Hariprasad Kelam , Jason Yan , zhengbin , Jia-Ju Bai , reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/reiserfs: remove unused macros Message-ID: <20200121162329.GC5803@quack2.suse.cz> References: <1579602338-57079-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579602338-57079-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 21-01-20 18:25:38, Alex Shi wrote: > these macros are never used from introduced. better to > remove them. > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Jan Kara > Cc: Bharath Vedartham > Cc: Hariprasad Kelam > Cc: Jason Yan > Cc: zhengbin > Cc: Jia-Ju Bai > Cc: reiserfs-devel@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Thanks. I've added the patch to my tree. Honza > --- > fs/reiserfs/journal.c | 2 -- > fs/reiserfs/procfs.c | 1 - > fs/reiserfs/stree.c | 6 ------ > 3 files changed, 9 deletions(-) > > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c > index 4b3e3e73b512..072156c4f895 100644 > --- a/fs/reiserfs/journal.c > +++ b/fs/reiserfs/journal.c > @@ -56,8 +56,6 @@ > /* gets a struct reiserfs_journal_list * from a list head */ > #define JOURNAL_LIST_ENTRY(h) (list_entry((h), struct reiserfs_journal_list, \ > j_list)) > -#define JOURNAL_WORK_ENTRY(h) (list_entry((h), struct reiserfs_journal_list, \ > - j_working_list)) > > /* must be correct to keep the desc and commit structs at 4k */ > #define JOURNAL_TRANS_HALF 1018 > diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c > index f2cf3441fdfc..ff336513c254 100644 > --- a/fs/reiserfs/procfs.c > +++ b/fs/reiserfs/procfs.c > @@ -63,7 +63,6 @@ static int show_version(struct seq_file *m, void *unused) > #define MAP( i ) D4C( objectid_map( sb, rs )[ i ] ) > > #define DJF( x ) le32_to_cpu( rs -> x ) > -#define DJV( x ) le32_to_cpu( s_v1 -> x ) > #define DJP( x ) le32_to_cpu( jp -> x ) > #define JF( x ) ( r -> s_journal -> x ) > > diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c > index da9ebe33882b..6051e7bbc221 100644 > --- a/fs/reiserfs/stree.c > +++ b/fs/reiserfs/stree.c > @@ -918,12 +918,6 @@ int comp_items(const struct item_head *stored_ih, const struct treepath *path) > return memcmp(stored_ih, ih, IH_SIZE); > } > > -/* unformatted nodes are not logged anymore, ever. This is safe now */ > -#define held_by_others(bh) (atomic_read(&(bh)->b_count) > 1) > - > -/* block can not be forgotten as it is in I/O or held by someone */ > -#define block_in_use(bh) (buffer_locked(bh) || (held_by_others(bh))) > - > /* prepare for delete or cut of direct item */ > static inline int prepare_for_direct_item(struct treepath *path, > struct item_head *le_ih, > -- > 1.8.3.1 > -- Jan Kara SUSE Labs, CR