From: Rob Herring <robh@kernel.org>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kishon@ti.com,
devicetree@vger.kernel.org, cheol.yong.kim@intel.com,
andriy.shevchenko@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error
Date: Tue, 21 Jan 2020 16:14:49 -0600 [thread overview]
Message-ID: <20200121221449.GA25322@bogus> (raw)
In-Reply-To: <20200114104710.23135-1-vadivel.muruganx.ramuthevar@linux.intel.com>
On Tue, Jan 14, 2020 at 06:47:10PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> This patch fixes the devicetree binding yaml build errors
> in linux-next kernel Error: Documentation/devicetree/bindings/
> phy/intel,lgm-emmc-phy.example.dts:21.19-20
> syntax error FATAL ERROR: Unable to parse input tree
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> Reported-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/phy/intel,lgm-emmc-phy.yaml | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> index ff7959c21af0..d9bd2e47dfe7 100644
> --- a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> @@ -16,10 +16,7 @@ description: |+
> The eMMC PHY node should be the child of a syscon node with the
> required property:
>
> - - compatible: Should be one of the following:
> - "intel,lgm-syscon", "syscon"
> - - reg:
> - maxItems: 1
> + should be compatible strings are - "intel,lgm-syscon", "syscon"
What's this change for?
>
> properties:
> compatible:
> @@ -34,6 +31,12 @@ properties:
> clocks:
> maxItems: 1
>
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
> +
This schema is properties in the emmc-phy node, so these don't belong
here. But the example change is correct.
> required:
> - "#phy-cells"
> - compatible
> @@ -45,8 +48,10 @@ examples:
> sysconf: chiptop@e0200000 {
> compatible = "intel,lgm-syscon", "syscon";
> reg = <0xe0200000 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> - emmc-phy: emmc-phy@a8 {
> + emmc_phy: emmc_phy@a8 {
Don't use '_' in node names. The error was in the label.
emmc_phy: emmc-phy@a8 {
> compatible = "intel,lgm-emmc-phy";
> reg = <0x00a8 0x10>;
> clocks = <&emmc>;
> --
> 2.11.0
>
prev parent reply other threads:[~2020-01-21 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 10:47 [PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error Ramuthevar,Vadivel MuruganX
2020-01-21 22:14 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121221449.GA25322@bogus \
--to=robh@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).