From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D042C2D0DB for ; Wed, 22 Jan 2020 09:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA7972467B for ; Wed, 22 Jan 2020 09:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579686601; bh=P+15TQf4p8PgRDquc4qBLe74dlyOXsfLeByMgiv4dSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hH0Eofszfi8RAu1+zY/iROjwa7AqUkHQG3Fje+wx/EGge8Xnb0asA4E+l55vFwD3N XzZXZx9pnI+uaGb7tnxCkHukDTjMq3aYNTGHTTsUk5H3kp+L0ziFlEDPE5Jpsl2Mty IWL2+oUeg7VDwAZdGRNlMqTESI88VaohJYXBCzc0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729971AbgAVJuA (ORCPT ); Wed, 22 Jan 2020 04:50:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:56628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732375AbgAVJjL (ORCPT ); Wed, 22 Jan 2020 04:39:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 874C924683; Wed, 22 Jan 2020 09:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579685951; bh=P+15TQf4p8PgRDquc4qBLe74dlyOXsfLeByMgiv4dSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dCsaZ9uWE1m8gdMzDSCdUNRhgR72Esb2uUxHxVqhWGJ5v6FCHa9A0ULZda+XV842U R2ZzmmG0MlFbOp31XmQhvWist8WxC7y3r9FW2B46HHQ8McogeHXLN4rOmRNL9bSLF1 Njnze2TSSBnJNjVy3Yb+b8A46B21/5IQI+W06Fog= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, hayeswang , Johan Hovold , "David S. Miller" Subject: [PATCH 4.14 48/65] r8152: add missing endpoint sanity check Date: Wed, 22 Jan 2020 10:29:33 +0100 Message-Id: <20200122092758.061703243@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092750.976732974@linuxfoundation.org> References: <20200122092750.976732974@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold [ Upstream commit 86f3f4cd53707ceeec079b83205c8d3c756eca93 ] Add missing endpoint sanity check to probe in order to prevent a NULL-pointer dereference (or slab out-of-bounds access) when retrieving the interrupt-endpoint bInterval on ndo_open() in case a device lacks the expected endpoints. Fixes: 40a82917b1d3 ("net/usb/r8152: enable interrupt transfer") Cc: hayeswang Signed-off-by: Johan Hovold Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/r8152.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -5158,6 +5158,9 @@ static int rtl8152_probe(struct usb_inte return -ENODEV; } + if (intf->cur_altsetting->desc.bNumEndpoints < 3) + return -ENODEV; + usb_reset_device(udev); netdev = alloc_etherdev(sizeof(struct r8152)); if (!netdev) {