From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5DFC2D0DB for ; Wed, 22 Jan 2020 13:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FEAF205F4 for ; Wed, 22 Jan 2020 13:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579699726; bh=5FSKRFfW6wddOTy4Vlusz6443sxjlfwb3l7KRaDwDng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oHQ05tIRffqkDfYUyq+EawqehegPAWkZfwpA79SMpiXi6w8xGcoBGYf3mqy2EPaJH FPGjpahZAxwbq7hetJsbLi4EvWiLbdQoG3tYsKy9TW7L7pDVYgFpGLfkswWHytVElS KXYEBDLX+HMiHGPyzTvRga2CagchBDEydHqlzY+M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731717AbgAVN2p (ORCPT ); Wed, 22 Jan 2020 08:28:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:51084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731597AbgAVN2k (ORCPT ); Wed, 22 Jan 2020 08:28:40 -0500 Received: from localhost (unknown [84.241.205.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF65820678; Wed, 22 Jan 2020 13:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579699719; bh=5FSKRFfW6wddOTy4Vlusz6443sxjlfwb3l7KRaDwDng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rPzjafmdp+fA/N0eVzY5xeLB14rlqc9bMGrINDkVAkXXWFehIX5xHzdgPmMjcIyJh 3yBH3SajcVkC5EOMRTVNrFJpUJ8luBKMuVT0Je3AHzGNZvlBl0ehwc7fcT0l3Zx0W5 F8bn+/l7a3uGBBGZREQnYrywi1jIZHw9LJdcmdBk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg , Richard Weinberger Subject: [PATCH 5.4 196/222] um: Dont trace irqflags during shutdown Date: Wed, 22 Jan 2020 10:29:42 +0100 Message-Id: <20200122092847.746688593@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092833.339495161@linuxfoundation.org> References: <20200122092833.339495161@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg commit 5c1f33e2a03c0b8710b5d910a46f1e1fb0607679 upstream. In the main() code, we eventually enable signals just before exec() or exit(), in order to to not have signals pending and delivered *after* the exec(). I've observed SIGSEGV loops at this point, and the reason seems to be the irqflags tracing; this makes sense as the kernel is no longer really functional at this point. Since there's really no reason to use unblock_signals_trace() here (I had just done a global search & replace), use the plain unblock_signals() in this case to avoid going into the no longer functional kernel. Fixes: 0dafcbe128d2 ("um: Implement TRACE_IRQFLAGS_SUPPORT") Signed-off-by: Johannes Berg Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- arch/um/os-Linux/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/um/os-Linux/main.c +++ b/arch/um/os-Linux/main.c @@ -170,7 +170,7 @@ int __init main(int argc, char **argv, c * that they won't be delivered after the exec, when * they are definitely not expected. */ - unblock_signals_trace(); + unblock_signals(); os_info("\n"); /* Reboot */