From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BBF0C3F68F for ; Thu, 23 Jan 2020 09:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01FAA2253D for ; Thu, 23 Jan 2020 09:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579772802; bh=7Alrt1l07JnyIcsP7ghtLDcrRLkxYPvcmDr5ZXRlgpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nD8diNmYwVg6ta6VYgnTRBLG8J1lJp/UmOK48yn0sjY16ObAfuD47bXlrtm9ov8tP yklVd+pTb+RYOgQi2g9gghZS8hjUlgztLpnL4r35qY5Ah3M5zEya7rzOehxoa0sh2p IRYpbTAw3bALCqRVN2C29qys0bFhShtbCCc4wc5Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgAWJql (ORCPT ); Thu, 23 Jan 2020 04:46:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:47878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbgAWJqk (ORCPT ); Thu, 23 Jan 2020 04:46:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 086BB22522; Thu, 23 Jan 2020 09:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579772799; bh=7Alrt1l07JnyIcsP7ghtLDcrRLkxYPvcmDr5ZXRlgpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ENtbD/uh6Pqjdn9WFWODdqUutSw/R1WugIL7U4BByfZrl1IJeYwZMF8iYVJzF0F9o NHoJFtygbq5t70f/WGFvKEu0r0BkQiLLZBb7aUSkgOjTRAegAIfbQYTQeBSgUyqsZP 3fABM8QMtRgpK9qmPNwQWQBFM2yQIyiB7jVf3POs= Date: Thu, 23 Jan 2020 10:46:37 +0100 From: Greg KH To: Chris Wilson Cc: Andrew Morton , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, lwn@lwn.net, Jiri Slaby Subject: Re: Linux 4.19.98 Message-ID: <20200123094637.GB661791@kroah.com> References: <20200123084632.GA435419@kroah.com> <157976968555.18920.13404367012873725550@skylake-alporthouse-com> <20200123092832.GA586919@kroah.com> <157977223818.18920.13596879587159565742@skylake-alporthouse-com> <20200123094508.GA661791@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123094508.GA661791@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 10:45:08AM +0100, Greg KH wrote: > On Thu, Jan 23, 2020 at 09:37:18AM +0000, Chris Wilson wrote: > > Quoting Greg KH (2020-01-23 09:28:32) > > > On Thu, Jan 23, 2020 at 08:54:45AM +0000, Chris Wilson wrote: > > > > Quoting Greg KH (2020-01-23 08:46:32) > > > > > I'm announcing the release of the 4.19.98 kernel. > > > > > > > > commit 3e6b472f474accf757e107919f8ee42e7315ac0d > > > > Author: Waiman Long > > > > Date: Wed Nov 14 09:55:40 2018 -0800 > > > > > > > > efi: Fix debugobjects warning on 'efi_rts_work' > > > > > > > > [ Upstream commit ef1491e791308317bb9851a0ad380c4a68b58d54 ] > > > > > > > > The following commit: > > > > > > > > 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") > > > > > > > > converted 'efi_rts_work' from an auto variable to a global variable. > > > > However, when submitting the work, INIT_WORK_ONSTACK() was still used, > > > > causing the following complaint from debugobjects: > > > > > > > > ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but annotated. > > > > > > > > Change the macro to just INIT_WORK() to eliminate the warning. > > > > > > > > Signed-off-by: Waiman Long > > > > Signed-off-by: Ard Biesheuvel > > > > Acked-by: Sai Praneeth Prakhya > > > > Cc: Linus Torvalds > > > > Cc: Peter Zijlstra > > > > Cc: Thomas Gleixner > > > > Cc: linux-efi@vger.kernel.org > > > > Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") > > > > Link: http://lkml.kernel.org/r/20181114175544.12860-2-ard.biesheuvel@linaro.org > > > > Signed-off-by: Ingo Molnar > > > > Signed-off-by: Sasha Levin > > > > > > > > was incorrectly applied to v4.19.41 and causes lockdep complaints for > > > > the onstack efi_rts_work being initialised by INIT_WORK(). > > > > > > Incorrectly how? Fuzz off, or it shouldn't be applied at all? Should > > > this be reverted, or just fixed up, and if fixed up, do you have a patch > > > to fix it? > > > > Just reverted. It applies to 9dbbedaa6171 which moved the efi_rts_work > > off the stack, but is not in v4.19.y, so efi_rts_work is still a local > > and needs the INIT_WORK_ONSTACK annotation. > > Ok, thanks, will go revert this and push out a new release with that > fix, thanks for letting me know. Wait, that commit happened back in 4.19.41 which was released in May 2019, so I don't think this is a rush, right? I'll just queue it up for the next release instead of pushing out a rush one, thanks. greg k-h