linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
@ 2020-01-07  8:12 Krzysztof Kozlowski
  2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-07  8:12 UTC (permalink / raw)
  To: Wolfram Sang, Jean Delvare, Jarkko Nikula, Krzysztof Kozlowski,
	linux-i2c, linux-kernel
  Cc: Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

Some of the I2C bus drivers can be compile tested to increase build
coverage.  This requires also:
1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
   controllers,
2. Adding 'if' conditional to 'default y' so they will not get enabled
   by default on all other architectures,
3. Limiting few compile test options to supported architectures (which
   provide the readsX()/writesX() primitives).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Address Geert's comments (split depends, comment on weird
   architecture selection).
---
 drivers/i2c/busses/Kconfig | 66 +++++++++++++++++++++++++---------------------
 1 file changed, 36 insertions(+), 30 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 6a0aa76859f3..132e6f374cd7 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -367,7 +367,8 @@ comment "I2C system bus drivers (mostly embedded / system-on-chip)"
 
 config I2C_ALTERA
 	tristate "Altera Soft IP I2C"
-	depends on (ARCH_SOCFPGA || NIOS2) && OF
+	depends on ARCH_SOCFPGA || NIOS2 || COMPILE_TEST
+	depends on OF
 	help
 	  If you say yes to this option, support will be included for the
 	  Altera Soft IP I2C interfaces on SoCFPGA and Nios2 architectures.
@@ -387,7 +388,7 @@ config I2C_ASPEED
 
 config I2C_AT91
 	tristate "Atmel AT91 I2C Two-Wire interface (TWI)"
-	depends on ARCH_AT91
+	depends on ARCH_AT91 || COMPILE_TEST
 	help
 	  This supports the use of the I2C interface on Atmel AT91
 	  processors.
@@ -440,7 +441,8 @@ config I2C_AXXIA
 
 config I2C_BCM2835
 	tristate "Broadcom BCM2835 I2C controller"
-	depends on ARCH_BCM2835 || ARCH_BRCMSTB
+	depends on ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST
+	depends on COMMON_CLK
 	help
 	  If you say yes to this option, support will be included for the
 	  BCM2835 I2C controller.
@@ -463,8 +465,8 @@ config I2C_BCM_IPROC
 
 config I2C_BCM_KONA
 	tristate "BCM Kona I2C adapter"
-	depends on ARCH_BCM_MOBILE
-	default y
+	depends on ARCH_BCM_MOBILE || COMPILE_TEST
+	default y if ARCH_BCM_MOBILE
 	help
 	  If you say yes to this option, support will be included for the
 	  I2C interface on the Broadcom Kona family of processors.
@@ -511,7 +513,7 @@ config I2C_CPM
 
 config I2C_DAVINCI
 	tristate "DaVinci I2C driver"
-	depends on ARCH_DAVINCI || ARCH_KEYSTONE
+	depends on ARCH_DAVINCI || ARCH_KEYSTONE || COMPILE_TEST
 	help
 	  Support for TI DaVinci I2C controller driver.
 
@@ -572,7 +574,7 @@ config I2C_DESIGNWARE_BAYTRAIL
 
 config I2C_DIGICOLOR
 	tristate "Conexant Digicolor I2C driver"
-	depends on ARCH_DIGICOLOR
+	depends on ARCH_DIGICOLOR || COMPILE_TEST
 	help
 	  Support for Conexant Digicolor SoCs (CX92755) I2C controller driver.
 
@@ -611,8 +613,9 @@ config I2C_EMEV2
 
 config I2C_EXYNOS5
 	tristate "Exynos5 high-speed I2C driver"
-	depends on ARCH_EXYNOS && OF
-	default y
+	depends on OF
+	depends on ARCH_EXYNOS || COMPILE_TEST
+	default y if ARCH_EXYNOS
 	help
 	  High-speed I2C controller on Exynos5 based Samsung SoCs.
 
@@ -634,7 +637,7 @@ config I2C_GPIO_FAULT_INJECTOR
 
 config I2C_HIGHLANDER
 	tristate "Highlander FPGA SMBus interface"
-	depends on SH_HIGHLANDER
+	depends on SH_HIGHLANDER || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for
 	  the SMBus interface located in the FPGA on various Highlander
@@ -686,7 +689,7 @@ config I2C_IMX_LPI2C
 
 config I2C_IOP3XX
 	tristate "Intel IOPx3xx and IXP4xx on-chip I2C interface"
-	depends on ARCH_IOP32X || ARCH_IXP4XX
+	depends on ARCH_IOP32X || ARCH_IXP4XX || COMPILE_TEST
 	help
 	  Say Y here if you want to use the IIC bus controller on
 	  the Intel IOPx3xx I/O Processors or IXP4xx Network Processors.
@@ -726,6 +729,7 @@ config I2C_LPC2K
 config I2C_MESON
 	tristate "Amlogic Meson I2C controller"
 	depends on ARCH_MESON || COMPILE_TEST
+	depends on COMMON_CLK
 	help
 	  If you say yes to this option, support will be included for the
 	  I2C interface on the Amlogic Meson family of SoCs.
@@ -759,7 +763,7 @@ config I2C_MT7621
 
 config I2C_MV64XXX
 	tristate "Marvell mv64xxx I2C Controller"
-	depends on MV64X60 || PLAT_ORION || ARCH_SUNXI || ARCH_MVEBU
+	depends on MV64X60 || PLAT_ORION || ARCH_SUNXI || ARCH_MVEBU || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Marvell 64xxx line of host bridges.
@@ -770,7 +774,7 @@ config I2C_MV64XXX
 
 config I2C_MXS
 	tristate "Freescale i.MX28 I2C interface"
-	depends on SOC_IMX28
+	depends on SOC_IMX28 || COMPILE_TEST
 	select STMP_DEVICE
 	help
 	  Say Y here if you want to use the I2C bus controller on
@@ -799,7 +803,7 @@ config I2C_OCORES
 
 config I2C_OMAP
 	tristate "OMAP I2C adapter"
-	depends on ARCH_OMAP || ARCH_K3
+	depends on ARCH_OMAP || ARCH_K3 || COMPILE_TEST
 	default y if MACH_OMAP_H3 || MACH_OMAP_OSK
 	help
 	  If you say yes to this option, support will be included for the
@@ -833,7 +837,7 @@ config I2C_PCA_PLATFORM
 
 config I2C_PMCMSP
 	tristate "PMC MSP I2C TWI Controller"
-	depends on PMC_MSP
+	depends on PMC_MSP || COMPILE_TEST
 	help
 	  This driver supports the PMC TWI controller on MSP devices.
 
@@ -842,7 +846,7 @@ config I2C_PMCMSP
 
 config I2C_PNX
 	tristate "I2C bus support for Philips PNX and NXP LPC targets"
-	depends on ARCH_LPC32XX
+	depends on ARCH_LPC32XX || COMPILE_TEST
 	help
 	  This driver supports the Philips IP3204 I2C IP block master and/or
 	  slave controller
@@ -863,7 +867,7 @@ config I2C_PUV3
 
 config I2C_PXA
 	tristate "Intel PXA2XX I2C adapter"
-	depends on ARCH_PXA || ARCH_MMP || ARCH_MVEBU || (X86_32 && PCI && OF)
+	depends on ARCH_PXA || ARCH_MMP || ARCH_MVEBU || (X86_32 && PCI && OF) || COMPILE_TEST
 	help
 	  If you have devices in the PXA I2C bus, say yes to this option.
 	  This driver can also be built as a module.  If so, the module
@@ -933,7 +937,7 @@ config HAVE_S3C2410_I2C
 
 config I2C_S3C2410
 	tristate "S3C2410 I2C Driver"
-	depends on HAVE_S3C2410_I2C
+	depends on HAVE_S3C2410_I2C || COMPILE_TEST
 	help
 	  Say Y here to include support for I2C controller in the
 	  Samsung SoCs.
@@ -971,7 +975,7 @@ config I2C_SIMTEC
 
 config I2C_SIRF
 	tristate "CSR SiRFprimaII I2C interface"
-	depends on ARCH_SIRF
+	depends on ARCH_SIRF || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  CSR SiRFprimaII I2C interface.
@@ -981,14 +985,14 @@ config I2C_SIRF
 
 config I2C_SPRD
 	tristate "Spreadtrum I2C interface"
-	depends on I2C=y && ARCH_SPRD
+	depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
 	help
 	  If you say yes to this option, support will be included for the
 	  Spreadtrum I2C interface.
 
 config I2C_ST
 	tristate "STMicroelectronics SSC I2C support"
-	depends on ARCH_STI
+	depends on ARCH_STI || COMPILE_TEST
 	help
 	  Enable this option to add support for STMicroelectronics SoCs
 	  hardware SSC (Synchronous Serial Controller) as an I2C controller.
@@ -1019,7 +1023,7 @@ config I2C_STM32F7
 
 config I2C_STU300
 	tristate "ST Microelectronics DDC I2C interface"
-	depends on MACH_U300
+	depends on MACH_U300 || COMPILE_TEST
 	default y if MACH_U300
 	help
 	  If you say yes to this option, support will be included for the
@@ -1055,15 +1059,16 @@ config I2C_SYNQUACER
 
 config I2C_TEGRA
 	tristate "NVIDIA Tegra internal I2C controller"
-	depends on ARCH_TEGRA
+	depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
+	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
 	help
 	  If you say yes to this option, support will be included for the
 	  I2C controller embedded in NVIDIA Tegra SOCs
 
 config I2C_TEGRA_BPMP
 	tristate "NVIDIA Tegra BPMP I2C controller"
-	depends on TEGRA_BPMP
-	default y
+	depends on TEGRA_BPMP || COMPILE_TEST
+	default y if TEGRA_BPMP
 	help
 	  If you say yes to this option, support will be included for the I2C
 	  controller embedded in NVIDIA Tegra SoCs accessed via the BPMP.
@@ -1101,7 +1106,7 @@ config I2C_VERSATILE
 
 config I2C_WMT
 	tristate "Wondermedia WM8xxx SoC I2C bus support"
-	depends on ARCH_VT8500
+	depends on ARCH_VT8500 || COMPILE_TEST
 	help
 	  Say yes if you want to support the I2C bus on Wondermedia 8xxx-series
 	  SoCs.
@@ -1142,7 +1147,7 @@ config I2C_XILINX
 
 config I2C_XLR
 	tristate "Netlogic XLR and Sigma Designs I2C support"
-	depends on CPU_XLR || ARCH_TANGO
+	depends on CPU_XLR || ARCH_TANGO || COMPILE_TEST
 	help
 	  This driver enables support for the on-chip I2C interface of
 	  the Netlogic XLR/XLS MIPS processors and Sigma Designs SOCs.
@@ -1328,7 +1333,7 @@ config I2C_ICY
 
 config I2C_MLXCPLD
 	tristate "Mellanox I2C driver"
-	depends on X86_64
+	depends on X86_64 || COMPILE_TEST
 	help
 	  This exposes the Mellanox platform I2C busses to the linux I2C layer
 	  for X86 based systems.
@@ -1403,8 +1408,9 @@ config I2C_OPAL
 
 config I2C_ZX2967
 	tristate "ZTE ZX2967 I2C support"
-	depends on ARCH_ZX
-	default y
+	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
+	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
+	default y if ARCH_ZX
 	help
 	  Selecting this option will add ZX2967 I2C driver.
 	  This driver can also be built as a module. If so, the module will be
-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation
  2020-01-07  8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
@ 2020-01-07  8:12 ` Krzysztof Kozlowski
  2020-01-23  9:13   ` Wolfram Sang
  2020-01-23 10:59   ` Wolfram Sang
  2020-01-23  9:12 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Wolfram Sang
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-07  8:12 UTC (permalink / raw)
  To: Wolfram Sang, Jean Delvare, Jarkko Nikula, Krzysztof Kozlowski,
	linux-i2c, linux-kernel
  Cc: Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

Update the help text to reflect current support devices:
1. The Exynos high speed I2C driver supports Exynos5 (ARMv7), Exynos5433
   and Exynos7 (both ARMv8) SoCs,
2. The S3C I2C driver supports S3C, S5Pv210 and Exynos{3,4,5} SoCs.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. New patch
---
 drivers/i2c/busses/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 132e6f374cd7..43984d5a7fad 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -612,12 +612,12 @@ config I2C_EMEV2
 	  I2C interface on the Renesas Electronics EM/EV family of processors.
 
 config I2C_EXYNOS5
-	tristate "Exynos5 high-speed I2C driver"
+	tristate "Exynos high-speed I2C driver"
 	depends on OF
 	depends on ARCH_EXYNOS || COMPILE_TEST
 	default y if ARCH_EXYNOS
 	help
-	  High-speed I2C controller on Exynos5 based Samsung SoCs.
+	  High-speed I2C controller on Exynos5 and newer Samsung SoCs.
 
 config I2C_GPIO
 	tristate "GPIO-based bitbanging I2C"
@@ -936,11 +936,11 @@ config HAVE_S3C2410_I2C
 	  respective Kconfig file.
 
 config I2C_S3C2410
-	tristate "S3C2410 I2C Driver"
+	tristate "S3C/Exynos I2C Driver"
 	depends on HAVE_S3C2410_I2C || COMPILE_TEST
 	help
 	  Say Y here to include support for I2C controller in the
-	  Samsung SoCs.
+	  Samsung SoCs (S3C, S5Pv210, Exynos).
 
 config I2C_SH7760
 	tristate "Renesas SH7760 I2C Controller"
-- 
2.7.4


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-07  8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
  2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
@ 2020-01-23  9:12 ` Wolfram Sang
  2020-01-23  9:31   ` Krzysztof Kozlowski
  2020-01-23 10:59 ` Wolfram Sang
  2020-01-23 15:31 ` Marc Gonzalez
  3 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2020-01-23  9:12 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]


>  config I2C_ZX2967
>  	tristate "ZTE ZX2967 I2C support"
> -	depends on ARCH_ZX
> -	default y
> +	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> +	# COMPILE_TEST needs architectures with readsX()/writesX() primitives

The list of archs neither looks pretty nor very maintainable. My
suggestion is that we leave this out of COMPILE_TEST until we have
something like ARCH_HAS_READS or something. What do you think?

> +	default y if ARCH_ZX



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation
  2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
@ 2020-01-23  9:13   ` Wolfram Sang
  2020-01-23 10:59   ` Wolfram Sang
  1 sibling, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-01-23  9:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

On Tue, Jan 07, 2020 at 09:12:59AM +0100, Krzysztof Kozlowski wrote:
> Update the help text to reflect current support devices:
> 1. The Exynos high speed I2C driver supports Exynos5 (ARMv7), Exynos5433
>    and Exynos7 (both ARMv8) SoCs,
> 2. The S3C I2C driver supports S3C, S5Pv210 and Exynos{3,4,5} SoCs.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Looks good. Let's discuss this one question of patch 1 and we are good
to go!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-23  9:12 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Wolfram Sang
@ 2020-01-23  9:31   ` Krzysztof Kozlowski
  2020-01-23  9:41     ` Wolfram Sang
  0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-23  9:31 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> 
> >  config I2C_ZX2967
> >  	tristate "ZTE ZX2967 I2C support"
> > -	depends on ARCH_ZX
> > -	default y
> > +	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > +	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
> 
> The list of archs neither looks pretty nor very maintainable. My
> suggestion is that we leave this out of COMPILE_TEST until we have
> something like ARCH_HAS_READS or something. What do you think?

Indeed it does not look good. However having compile testing allows
kbuild to run sparse and smatch which already started pointing minor
issues in existing drivers.

Yeah... pros and cons... I don't have a strong opinion to keep it. Since
patch is important, maybe let's just skip this part?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-23  9:31   ` Krzysztof Kozlowski
@ 2020-01-23  9:41     ` Wolfram Sang
  2020-01-23 10:00       ` Krzysztof Kozlowski
  2020-01-23 12:46       ` Uwe Kleine-König
  0 siblings, 2 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-01-23  9:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On Thu, Jan 23, 2020 at 10:31:20AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> > 
> > >  config I2C_ZX2967
> > >  	tristate "ZTE ZX2967 I2C support"
> > > -	depends on ARCH_ZX
> > > -	default y
> > > +	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > > +	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
> > 
> > The list of archs neither looks pretty nor very maintainable. My
> > suggestion is that we leave this out of COMPILE_TEST until we have
> > something like ARCH_HAS_READS or something. What do you think?
> 
> Indeed it does not look good. However having compile testing allows
> kbuild to run sparse and smatch which already started pointing minor
> issues in existing drivers.
> 
> Yeah... pros and cons... I don't have a strong opinion to keep it. Since
> patch is important, maybe let's just skip this part?

Yeah, let's skip it for now. If you or someone is keen on having it,
something like ARCH_HAS_READS (<- needs better name) should be
introduced so we can use it here. But that can/should be handled
incrementally.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-23  9:41     ` Wolfram Sang
@ 2020-01-23 10:00       ` Krzysztof Kozlowski
  2020-01-23 12:46       ` Uwe Kleine-König
  1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-23 10:00 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

On Thu, Jan 23, 2020 at 10:41:07AM +0100, Wolfram Sang wrote:
> On Thu, Jan 23, 2020 at 10:31:20AM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> > > 
> > > >  config I2C_ZX2967
> > > >  	tristate "ZTE ZX2967 I2C support"
> > > > -	depends on ARCH_ZX
> > > > -	default y
> > > > +	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > > > +	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
> > > 
> > > The list of archs neither looks pretty nor very maintainable. My
> > > suggestion is that we leave this out of COMPILE_TEST until we have
> > > something like ARCH_HAS_READS or something. What do you think?
> > 
> > Indeed it does not look good. However having compile testing allows
> > kbuild to run sparse and smatch which already started pointing minor
> > issues in existing drivers.
> > 
> > Yeah... pros and cons... I don't have a strong opinion to keep it. Since
> > patch is important, maybe let's just skip this part?
> 
> Yeah, let's skip it for now. If you or someone is keen on having it,
> something like ARCH_HAS_READS (<- needs better name) should be
> introduced so we can use it here. But that can/should be handled
> incrementally.

Shall I send v3 or mayybe can you apply without this hunk?

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-07  8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
  2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
  2020-01-23  9:12 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Wolfram Sang
@ 2020-01-23 10:59 ` Wolfram Sang
  2020-01-23 15:31 ` Marc Gonzalez
  3 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-01-23 10:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

On Tue, Jan 07, 2020 at 09:12:58AM +0100, Krzysztof Kozlowski wrote:
> Some of the I2C bus drivers can be compile tested to increase build
> coverage.  This requires also:
> 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
>    controllers,
> 2. Adding 'if' conditional to 'default y' so they will not get enabled
>    by default on all other architectures,
> 3. Limiting few compile test options to supported architectures (which
>    provide the readsX()/writesX() primitives).
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

Applied to for-next with the zx chunk removed, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation
  2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
  2020-01-23  9:13   ` Wolfram Sang
@ 2020-01-23 10:59   ` Wolfram Sang
  1 sibling, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2020-01-23 10:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Jarkko Nikula, linux-i2c, linux-kernel,
	Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Tue, Jan 07, 2020 at 09:12:59AM +0100, Krzysztof Kozlowski wrote:
> Update the help text to reflect current support devices:
> 1. The Exynos high speed I2C driver supports Exynos5 (ARMv7), Exynos5433
>    and Exynos7 (both ARMv8) SoCs,
> 2. The S3C I2C driver supports S3C, S5Pv210 and Exynos{3,4,5} SoCs.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-23  9:41     ` Wolfram Sang
  2020-01-23 10:00       ` Krzysztof Kozlowski
@ 2020-01-23 12:46       ` Uwe Kleine-König
  1 sibling, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2020-01-23 12:46 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Krzysztof Kozlowski, Jean Delvare, Jarkko Nikula, linux-i2c,
	linux-kernel, Linux Next Mailing List, Kishon Vijay Abraham I,
	Greg KH, Stephen Rothwell, Geert Uytterhoeven, Linux ARM

On Thu, Jan 23, 2020 at 10:41:07AM +0100, Wolfram Sang wrote:
> On Thu, Jan 23, 2020 at 10:31:20AM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 23, 2020 at 10:12:28AM +0100, Wolfram Sang wrote:
> > > 
> > > >  config I2C_ZX2967
> > > >  	tristate "ZTE ZX2967 I2C support"
> > > > -	depends on ARCH_ZX
> > > > -	default y
> > > > +	depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
> > > > +	# COMPILE_TEST needs architectures with readsX()/writesX() primitives
> > > 
> > > The list of archs neither looks pretty nor very maintainable. My
> > > suggestion is that we leave this out of COMPILE_TEST until we have
> > > something like ARCH_HAS_READS or something. What do you think?
> > 
> > Indeed it does not look good. However having compile testing allows
> > kbuild to run sparse and smatch which already started pointing minor
> > issues in existing drivers.
> > 
> > Yeah... pros and cons... I don't have a strong opinion to keep it. Since
> > patch is important, maybe let's just skip this part?
> 
> Yeah, let's skip it for now. If you or someone is keen on having it,
> something like ARCH_HAS_READS (<- needs better name) should be
> introduced so we can use it here. But that can/should be handled
> incrementally.

Isn't this "HAS_IOMEM" already today? The driver compiles for me on
amd64, too, so ...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
  2020-01-07  8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2020-01-23 10:59 ` Wolfram Sang
@ 2020-01-23 15:31 ` Marc Gonzalez
  3 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2020-01-23 15:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Wolfram Sang, Jean Delvare, Jarkko Nikula,
	I2C, LKML
  Cc: Linux Next Mailing List, Kishon Vijay Abraham I, Greg KH,
	Stephen Rothwell, Geert Uytterhoeven, Linux ARM

On 07/01/2020 09:12, Krzysztof Kozlowski wrote:

> Some of the I2C bus drivers can be compile tested to increase build
> coverage.  This requires also:
> 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
>    controllers,
> 2. Adding 'if' conditional to 'default y' so they will not get enabled
>    by default on all other architectures,
> 3. Limiting few compile test options to supported architectures (which
>    provide the readsX()/writesX() primitives).
> 
>  config I2C_BCM_KONA
>  	tristate "BCM Kona I2C adapter"
> -	depends on ARCH_BCM_MOBILE
> -	default y
> +	depends on ARCH_BCM_MOBILE || COMPILE_TEST
> +	default y if ARCH_BCM_MOBILE

Why not the simpler:
default ARCH_BCM_MOBILE

Regards.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-01-23 15:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07  8:12 [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
2020-01-07  8:12 ` [PATCH v2 2/2] i2c: exynos: Update Kconfig documentation Krzysztof Kozlowski
2020-01-23  9:13   ` Wolfram Sang
2020-01-23 10:59   ` Wolfram Sang
2020-01-23  9:12 ` [PATCH v2 1/2] i2c: Enable compile testing for some of drivers Wolfram Sang
2020-01-23  9:31   ` Krzysztof Kozlowski
2020-01-23  9:41     ` Wolfram Sang
2020-01-23 10:00       ` Krzysztof Kozlowski
2020-01-23 12:46       ` Uwe Kleine-König
2020-01-23 10:59 ` Wolfram Sang
2020-01-23 15:31 ` Marc Gonzalez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).