From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F901C2D0DB for ; Thu, 23 Jan 2020 16:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBF2321D7D for ; Thu, 23 Jan 2020 16:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lM+qRMYp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbgAWQIq (ORCPT ); Thu, 23 Jan 2020 11:08:46 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39195 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbgAWQIn (ORCPT ); Thu, 23 Jan 2020 11:08:43 -0500 Received: by mail-pf1-f195.google.com with SMTP id q10so1744176pfs.6 for ; Thu, 23 Jan 2020 08:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=td46G8H/xG3KwKZVoWzOjjmv0BfVbkqqajOdOX1P7gY=; b=lM+qRMYpFmvxGN+/4LhnZq4sqRW6FLBBMnhUm0cU5iKquVddBZxPgV/elfaSzzEO77 vj3MsgXT9yuc/fP9pFOrTf+q0gQHGhRPHkoxFOhYkHqF6sCKpolIG+LqdkLSXFxQCh1c uLBvwDYe69yYr5Ab8NL9YcTU4dIQjwq7ctGUR/RKZ8jvjJddtbHpZFaK9eGVsAF+AsXR ZUOoCLEmDSHw6KuwivGzgSEpCB0BUXPv8GON4AkN/4lDqw2T8ObUpfi+vM5qE9uACjGh i7BKwexFGTKGtAhOgr6n6x6fd81CcOhuUpv+RrLuEz/wUcmxPEbQciYeMCw5jyTgIA5p ZFrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=td46G8H/xG3KwKZVoWzOjjmv0BfVbkqqajOdOX1P7gY=; b=R5YyKYRaK4OoG/Kq1sGvQhLwkWWMrt0wAFRA6QGDgYR3kb25M3F9SSwTRNRKQFPZI4 PeHvX4qFFyriIe0gfinbIq+yNN2MfzdgP6YPM8VGZGCdg5fVLgBrZpEw4I9Dqv8W/AVl pUOYFTN4dU30NnvW3YKhC5orB8nb4pPhN53qeGih3hsk5sRVImOoc+I65iccplCi5ycB seaWspZNS18bi0mz39xw9Wg6FiG+xLjygL05bO3W+l5f0+d594q40KMs4wNl2vsk5hKX bjjXt+K18ZDoNTjew4nDY95GHoRqobJB1yu6LYa2lQvWIajJ14gJuPIv3pCNDHi/Cqvw /gKg== X-Gm-Message-State: APjAAAXhLA1L9HBiz2wm6EUKpGJwK2fvbvElzl/lo2pi8QblEnvCggj9 JUzEa6+EMasZQvzHYJgwUzv+aA== X-Google-Smtp-Source: APXvYqyWFE/06GhooYKazl6pIep62Iz/i5wyCJpTVPsFAFVDTHngEfFdHOY7P3gqOAl2IQhW45vjSw== X-Received: by 2002:a63:4006:: with SMTP id n6mr4591570pga.139.1579795722829; Thu, 23 Jan 2020 08:08:42 -0800 (PST) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id u12sm3214680pfm.165.2020.01.23.08.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 08:08:42 -0800 (PST) Date: Thu, 23 Jan 2020 08:08:39 -0800 From: Bjorn Andersson To: Roja Rani Yarubandi Cc: Greg Kroah-Hartman , akashast@codeaurora.org, msavaliy@qti.qualcomm.com, mgautam@codeaurora.org, skakit@codeaurora.org, Andy Gross , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] tty: serial: qcom_geni_serial: Configure UART_IO_MACRO_CTRL register Message-ID: <20200123160839.GB3888@tuxbook-pro> References: <20200123124802.24862-1-rojay@codeaurora.org> <20200123124802.24862-2-rojay@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123124802.24862-2-rojay@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 23 Jan 04:48 PST 2020, Roja Rani Yarubandi wrote: > Configure UART_IO_MACRO_CTRL register if UART lines are swapped. > > Signed-off-by: Roja Rani Yarubandi > --- > drivers/tty/serial/qcom_geni_serial.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index ff63728a95f4..24b862937c1e 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -24,6 +24,7 @@ > > /* UART specific GENI registers */ > #define SE_UART_LOOPBACK_CFG 0x22c > +#define SE_UART_IO_MACRO_CTRL 0x240 > #define SE_UART_TX_TRANS_CFG 0x25c > #define SE_UART_TX_WORD_LEN 0x268 > #define SE_UART_TX_STOP_BIT_LEN 0x26c > @@ -1260,6 +1261,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) > int irq; > bool console = false; > struct uart_driver *drv; > + u32 val; > > if (of_device_is_compatible(pdev->dev.of_node, "qcom,geni-debug-uart")) > console = true; > @@ -1309,6 +1311,10 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) > return irq; > uport->irq = irq; > > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,pin_inverse", &val); This needs to be documented in the DT binding document. And I assume it's better suited as a bool property to be read using of_property_read_bool(). Also avoid '_' in property names and make it a '-'. Regards, Bjorn > + if (!ret) > + writel(val, uport->membase + SE_UART_IO_MACRO_CTRL); > + > irq_set_status_flags(uport->irq, IRQ_NOAUTOEN); > ret = devm_request_irq(uport->dev, uport->irq, qcom_geni_serial_isr, > IRQF_TRIGGER_HIGH, port->name, uport); > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of the Code Aurora Forum, hosted by The Linux Foundation >