From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B6EC2D0DB for ; Fri, 24 Jan 2020 09:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5368421556 for ; Fri, 24 Jan 2020 09:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859188; bh=lHxq1JqKdhfX11T30D6KrSNCcT0eUQzGVvzSbMAAPNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wHQs8Lj+HKBi8D3V9ztT569Oat52CSxRTnelbbYsDUadCG5vziB3Wb2qsW58vKmKj poTgmNe9em++168a+bYVuDmuIx9cZRu4uOgZeJcNx6fdStFV+7LNOelHvJkT4xdv7u r7Kvtftbi/OC0bNzGo4hYhYswcf3O9C0Xd7M4LGw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387563AbgAXJq1 (ORCPT ); Fri, 24 Jan 2020 04:46:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:45668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbgAXJqW (ORCPT ); Fri, 24 Jan 2020 04:46:22 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87E9C208C4; Fri, 24 Jan 2020 09:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859182; bh=lHxq1JqKdhfX11T30D6KrSNCcT0eUQzGVvzSbMAAPNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bW7IQv7VQFYUAv6uYKYqnypInYXDULAnSWNYtqFcrwBgRJKHWtZn4JWh7hdDxvHqD dklg1x6tujb6U96W9I27bSxRjUGKwJpscMorM4SzsPZq6TojYGPebvLeQ37wfoBBCv s91WpdV2clv4SMEKJh/S9okDSy8cILYs4nmp0Zp8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 048/343] clk: imx6sx: fix refcount leak in imx6sx_clocks_init() Date: Fri, 24 Jan 2020 10:27:46 +0100 Message-Id: <20200124092926.053576455@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit 1731e14fb30212dd8c1e9f8fc1af061e56498c55 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: d55135689019 ("ARM: imx: add clock driver for imx6sx") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx6sx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c index e6d389e333d7d..baa07553a0ddc 100644 --- a/drivers/clk/imx/clk-imx6sx.c +++ b/drivers/clk/imx/clk-imx6sx.c @@ -164,6 +164,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6sx-anatop"); base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); clks[IMX6SX_PLL1_BYPASS_SRC] = imx_clk_mux("pll1_bypass_src", base + 0x00, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels)); clks[IMX6SX_PLL2_BYPASS_SRC] = imx_clk_mux("pll2_bypass_src", base + 0x30, 14, 1, pll_bypass_src_sels, ARRAY_SIZE(pll_bypass_src_sels)); -- 2.20.1