From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609FDC2D0DB for ; Fri, 24 Jan 2020 11:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AE9E20718 for ; Fri, 24 Jan 2020 11:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865475; bh=RSvTYQOq+dqRtFvcEwo6b1yZz81thGkC5mHRNSKdeQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PwwoSoZO/DkC9bw8ujFCoSkP0lQIK9M6F3qzKO1T9xSPcug4y3T0782JeT4nfUyCP PtajYi+Bj3OajCZCyAeKjdFxRHO1p/kBqrWFvA3zu5tf9MC/NU2/42+GSDXC/pN/Ci +Cb/cf1R/gTiOm+vxEHYtSahDOzwBVky29Rclpto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391851AbgAXLbO (ORCPT ); Fri, 24 Jan 2020 06:31:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:49430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391771AbgAXLbM (ORCPT ); Fri, 24 Jan 2020 06:31:12 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A537F206D4; Fri, 24 Jan 2020 11:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865472; bh=RSvTYQOq+dqRtFvcEwo6b1yZz81thGkC5mHRNSKdeQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RFExUUN4xyCnKkXpuBX3OnZWCiG5cOC0seKaIL6YRxVVXeneiF/LzMO3MZ8sWRBLb FyNpJq8KROgy1HrhhnmWwE2pSjqptxL4R337w0xBeQPn/TcjHWnpezj1yKJSsRFwX9 XLSJRZ8Br2h1aXwcfHX1bCwzFv5NlIEk2nQV6VUI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Borisov , Filipe Manana , David Sterba , Sasha Levin Subject: [PATCH 4.19 555/639] Btrfs: fix inode cache waiters hanging on path allocation failure Date: Fri, 24 Jan 2020 10:32:05 +0100 Message-Id: <20200124093158.757266300@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Filipe Manana [ Upstream commit 9d123a35d7e97bb2139747b16127c9b22b6a593e ] If the caching thread fails to allocate a path, it returns without waking up any cache waiters, leaving them hang forever. Fix this by following the same approach as when we fail to start the caching thread: print an error message, disable inode caching and make the wakers fallback to non-caching mode behaviour (calling btrfs_find_free_objectid()). Fixes: 581bb050941b4f ("Btrfs: Cache free inode numbers in memory") Reviewed-by: Nikolay Borisov Signed-off-by: Filipe Manana Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode-map.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c index 7c4d0107c6fb9..c7dcb7c521086 100644 --- a/fs/btrfs/inode-map.c +++ b/fs/btrfs/inode-map.c @@ -41,8 +41,10 @@ static int caching_kthread(void *data) return 0; path = btrfs_alloc_path(); - if (!path) + if (!path) { + fail_caching_thread(root); return -ENOMEM; + } /* Since the commit root is read-only, we can safely skip locking. */ path->skip_locking = 1; -- 2.20.1