From: Steven Rostedt <rostedt@goodmis.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
syzbot <syzbot+0c147ca7bd4352547635@syzkaller.appspotmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, netdev <netdev@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: WARNING in tracing_func_proto
Date: Fri, 24 Jan 2020 10:28:30 -0500 [thread overview]
Message-ID: <20200124102830.52911ff4@gandalf.local.home> (raw)
In-Reply-To: <CACT4Y+ZP-7np20GVRu3p+eZys9GPtbu+JpfV+HtsufAzvTgJrg@mail.gmail.com>
On Fri, 24 Jan 2020 11:44:13 +0100
Dmitry Vyukov <dvyukov@google.com> wrote:
> FWIW this is invalid use of WARN macros:
> https://elixir.bootlin.com/linux/v5.5-rc7/source/include/asm-generic/bug.h#L72
> This should be replaced with pr_err (if really necessary, kernel does
> not generally spew stacks on every ENOMEM/EINVAL).
That message was added in 2018. The WARN macro in question here, was
added in 2011. Thus, this would be more of a clean up fix.
>
> There are no _lots_ such wrong uses of WARN in the kernel. There were
> some, all get fixed over time, we are still discovering long tail, but
> it's like one per months at most. Note: syzbot reports each and every
> WARNING. If there were lots, you would notice :)
Hmm, I haven't looked, but are all these correct usage?
$ git grep WARN_ON HEAD | wc -l
15384
I also checked the number of WARN_ON when that WARN_ON was added:
$ git grep WARN_ON 07d777fe8c3985bc83428c2866713c2d1b3d4129 | wc -l
4730
A lot more were added since then!
>
> Sorting this out is critical for just any kernel testing. Otherwise no
> testing system will be able to say if a test triggers something bad in
> kernel or not.
>
> FWIW there are no local trees for syzbot. It only tests public trees
> as is. Doing otherwise would not work/scale as a process.
Anyway, I'll happily take a patch converting that WARN_ON macro to a
pr_err() print.
-- Steve
next prev parent reply other threads:[~2020-01-24 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 7:47 WARNING in tracing_func_proto syzbot
2020-01-21 23:02 ` Steven Rostedt
2020-01-22 5:53 ` Dan Carpenter
2020-01-24 10:44 ` Dmitry Vyukov
2020-01-24 15:28 ` Steven Rostedt [this message]
2020-03-06 6:54 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124102830.52911ff4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dan.carpenter@oracle.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+0c147ca7bd4352547635@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).