From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1F8C32771 for ; Fri, 24 Jan 2020 12:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B27F42070A for ; Fri, 24 Jan 2020 12:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579869916; bh=FvvLH9qER5DcnOnf1xVp/JzrsG2atF7HVEx+eP6psjg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0VlJArWhuJAhgR073w4ZIiRVJIl0jOCoStmersvgsWY8drU19b9lqrOiIyijydEzL IT/Nrw12ZyYnPSkEmhF8BQo+ney9oAsKztg+UVZNX6LdSsPM+W9V6LIoyksG/9u5Ok FFfgUxvVZU+IqCmyRJjIvT5THLepnQA3n3CPG6SM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388617AbgAXMpQ (ORCPT ); Fri, 24 Jan 2020 07:45:16 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35694 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387574AbgAXMpP (ORCPT ); Fri, 24 Jan 2020 07:45:15 -0500 Received: by mail-wm1-f67.google.com with SMTP id p17so1599246wmb.0; Fri, 24 Jan 2020 04:45:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j+mBBTpQJ4wbg8K52L8M4km/ID9qCvpn337om+dHJcg=; b=fdHlWwGYPjfw1Ny99VNqIHv7bDzqZDoVW4n0C8WSqvY63tYJ2HMLuDAMQwgCxjnBRv 8KEf0IQRR7pUczoEdpU70ftrD4wYXvZG/cnspnutGv+CfBNClBBfGiyy6Pm0Tqnsutc/ JPowucQAKQvfOuQa3GPqk8X4E0bkTEk+YRY5/gR61Fk+7oBviF/spObsda+0HDiJbnkZ DsOlGjJR2MwlNXSjpt1CeL47jlZ/buX/2QErkoOw1oxAjg90ijW1p+y/ZiCk3qQXaki2 7eQG1OdaLuwSHVz5b+wDmh4YuzjUjwpsGC4F3nTRNzifeC2eSwFvk4KKMAnD65ltq1RH RLCA== X-Gm-Message-State: APjAAAXRQUXIVFxj9It/7WgwhK1HmbmDY2npWkBvZcsTd4amJ4VhlaFk vG23a35xXUPLhsxNRAKq0NE= X-Google-Smtp-Source: APXvYqw48IZitTegCDEqW/DRYA1NjgNNLdiLHQ9/3fjlhxhOgsQMrqFvY7FUdFcstQQHzviWIpDW8Q== X-Received: by 2002:a1c:bc08:: with SMTP id m8mr2654997wmf.189.1579869913658; Fri, 24 Jan 2020 04:45:13 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id g25sm14465121wmh.3.2020.01.24.04.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 04:45:12 -0800 (PST) Date: Fri, 24 Jan 2020 13:45:12 +0100 From: Michal Hocko To: Dan Williams Cc: David Hildenbrand , Andrew Morton , stable , Vishal Verma , Pavel Tatashin , Dave Hansen , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH] mm/memory_hotplug: Fix remove_memory() lockdep splat Message-ID: <20200124124512.GT29276@dhcp22.suse.cz> References: <4d0334e2-c4e7-6d3f-99ba-2ca0495e1549@redhat.com> <64902066-51dd-9693-53fc-4a5975c58409@redhat.com> <516aa930-9b64-b377-557c-5413ed9fe336@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 10-01-20 13:27:24, Dan Williams wrote: > On Fri, Jan 10, 2020 at 9:42 AM David Hildenbrand wrote: [...] > > For your reference (roughly 5 months ago, so not that old) > > > > https://lkml.kernel.org/r/20190724143017.12841-1-david@redhat.com > > Oh, now I see the problem. You need to add that lock so far away from > the __add_memory() to avoid lock inversion problems with the > acpi_scan_lock. The organization I was envisioning would not work > without deeper refactoring. Sorry to come back to this late. Has this been resolved? -- Michal Hocko SUSE Labs