From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Praveen Chaudhary <praveen5582@gmail.com>
Cc: fw@strlen.de, davem@davemloft.net, kadlec@netfilter.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhenggen Xu <zxu@linkedin.com>,
Andy Stracner <astracner@linkedin.com>
Subject: Re: [PATCH v4] [net]: Fix skb->csum update in inet_proto_csum_replace16().
Date: Fri, 24 Jan 2020 20:04:32 +0100 [thread overview]
Message-ID: <20200124190432.vxcnnds3ypqa4hzh@salvia> (raw)
In-Reply-To: <1579811608-688-2-git-send-email-pchaudhary@linkedin.com>
On Thu, Jan 23, 2020 at 12:33:28PM -0800, Praveen Chaudhary wrote:
> skb->csum is updated incorrectly, when manipulation for NF_NAT_MANIP_SRC\DST
> is done on IPV6 packet.
>
> Fix:
> There is no need to update skb->csum in inet_proto_csum_replace16(), because
> update in two fields a.) IPv6 src/dst address and b.) L4 header checksum
> cancels each other for skb->csum calculation.
> Whereas inet_proto_csum_replace4 function needs to update skb->csum,
> because update in 3 fields a.) IPv4 src/dst address, b.) IPv4 Header checksum
> and c.) L4 header checksum results in same diff as L4 Header checksum for
> skb->csum calculation.
Applied, thanks.
next prev parent reply other threads:[~2020-01-24 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:52 [PATCH v3] [net]: Fix skb->csum update in inet_proto_csum_replace16() Praveen Chaudhary
2019-11-06 22:52 ` Praveen Chaudhary
2020-01-22 10:17 ` Daniel Borkmann
2020-01-22 11:43 ` Florian Westphal
2020-01-22 16:22 ` Daniel Borkmann
2020-01-23 8:21 ` Florian Westphal
2020-01-23 14:20 ` Daniel Borkmann
2020-01-23 14:29 ` Florian Westphal
2020-01-23 20:33 ` [PATCH v4] " Praveen Chaudhary
2020-01-23 20:33 ` Praveen Chaudhary
2020-01-24 19:04 ` Pablo Neira Ayuso [this message]
2020-01-23 20:50 ` [PATCH v3] " Praveen Chaudhary
2020-01-22 5:51 ` Praveen Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124190432.vxcnnds3ypqa4hzh@salvia \
--to=pablo@netfilter.org \
--cc=astracner@linkedin.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=praveen5582@gmail.com \
--cc=zxu@linkedin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).