From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Piotr Sroka <piotrs@cadence.com>,
linux-um <linux-um@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Gow <davidgow@google.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
Date: Sat, 25 Jan 2020 16:28:03 +0100 [thread overview]
Message-ID: <20200125162803.5a2375d7@xps13> (raw)
In-Reply-To: <CAFd5g47VLB6zOJsSySAYrJie8hj-OkvOC89-z2b9xMBZ2bxvYA@mail.gmail.com>
Hi Brendan,
Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020
18:12:12 -0800:
> On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Brendan,
> >
> > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> > 11:27:37 -0800:
> >
> > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > ---
> >
> > Sorry for the delay.
> >
> > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> It looks like my change has not been applied to nand/next; is this the
> branch it should be applied to? I have also verified that this patch
> isn't in linux-next as of Jan 24th.
>
> Is mtd/linux the correct tree for this? Or do I need to reach out to
> someone else?
When I sent my Acked-by I supposed someone else would pick the patch,
but there is actually no dependency with all the other patches so I
don't know why I did it... Sorry about that. I'll take it anyway in my
PR for 5.6.
Thanks,
Miquèl
next prev parent reply other threads:[~2020-01-25 15:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij
2020-01-23 22:15 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal [this message]
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125162803.5a2375d7@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bbrezillon@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=piotrs@cadence.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).