From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9943EC2D0DB for ; Sun, 26 Jan 2020 15:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F09320708 for ; Sun, 26 Jan 2020 15:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Qr6kFLjB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbgAZPwM (ORCPT ); Sun, 26 Jan 2020 10:52:12 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:15894 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbgAZPwM (ORCPT ); Sun, 26 Jan 2020 10:52:12 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580053931; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=JD2pxB6M6Wq/L05zP++/dLn61nN2ob1L8mfn2pSrEp8=; b=Qr6kFLjBvxuwJQgm1JjJlvSd2uh9SYn6KTq2p2uEmK+niZ5v1cmCKAMCA2nSjlo1pZdNIVXA eu4Ys2HRlvk4TWMzvpf7drZ0uHYQCopzny2baUK8l/KTdPOPWwEvrYj+bM1a0+L1tdkO5HI2 mWgDL5IQEW3phxvScX0MI/Huhlw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2db5a7.7f0d7ee0c340-smtp-out-n02; Sun, 26 Jan 2020 15:52:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5337DC4479C; Sun, 26 Jan 2020 15:52:06 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 75FB2C43383; Sun, 26 Jan 2020 15:52:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 75FB2C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop From: Kalle Valo In-Reply-To: <20200126000954.22807-1-colin.king@canonical.com> References: <20200126000954.22807-1-colin.king@canonical.com> To: Colin King Cc: Stanislaw Gruszka , "David S . Miller" , Meenakshi Venkataraman , Wey-Yi Guy , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200126155206.5337DC4479C@smtp.codeaurora.org> Date: Sun, 26 Jan 2020 15:52:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The loop counter addr is a u16 where as the upper limit of the loop > is an int. In the unlikely event that the il->cfg->eeprom_size is > greater than 64K then we end up with an infinite loop since addr will > wrap around an never reach upper loop limit. Fix this by making addr > an int. > > Addresses-Coverity: ("Infinite loop") > Fixes: be663ab67077 ("iwlwifi: split the drivers for agn and legacy devices 3945/4965") > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. c2f9a4e4a5ab iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop -- https://patchwork.kernel.org/patch/11351769/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches