From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA48C2D0DB for ; Sun, 26 Jan 2020 21:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFAC920716 for ; Sun, 26 Jan 2020 21:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgAZVkg (ORCPT ); Sun, 26 Jan 2020 16:40:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:54690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgAZVkf (ORCPT ); Sun, 26 Jan 2020 16:40:35 -0500 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC83220702; Sun, 26 Jan 2020 21:40:34 +0000 (UTC) Date: Sun, 26 Jan 2020 16:40:32 -0500 From: Steven Rostedt To: Joe Perches Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Dmitry Vyukov Subject: Re: [for-next][PATCH 7/7] tracing: Use pr_err() instead of WARN() for memory failures Message-ID: <20200126164032.7ac82cc0@rorschach.local.home> In-Reply-To: <5b221ac7e49666b76cd9ca368b37e721cfb4aa9c.camel@perches.com> References: <20200126191932.984391723@goodmis.org> <20200126192021.350763989@goodmis.org> <20200126155013.5cfc23aa@rorschach.local.home> <5b221ac7e49666b76cd9ca368b37e721cfb4aa9c.camel@perches.com> X-Mailer: Claws Mail 3.17.4git76 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Jan 2020 13:07:36 -0800 Joe Perches wrote: > > That sounds more generic. This is specific for my own tracing tests to > > look for. As the point is, it is *not* to dump_stack, and still report > > the error. > > __GFP_NOWARN is available too. I honestly don't care if there's a dump_stack or not. I just removed the WARN_ON. If the allocation causes a dump_stack() then that's fine, but I still like to have a bit more information at what failed to allocate, than just a offset into a function. The point of this patch was simply to remove WARN_ON() that caused fuzzers to fail. -- Steve