From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127FFC35240 for ; Mon, 27 Jan 2020 02:11:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA1DE20720 for ; Mon, 27 Jan 2020 02:11:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3eLgOqDQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727235AbgA0CLl (ORCPT ); Sun, 26 Jan 2020 21:11:41 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55158 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbgA0CLk (ORCPT ); Sun, 26 Jan 2020 21:11:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y7YuVKCXqFUYF08PynV1zLsYzbNxNQ3jNx/XdrnhwM8=; b=3eLgOqDQ92tcKjx7fglJfBqCAT BBS/OC4CDGd/+El84Ouvrof2JgBV+0d2Ni84XolBXFyNtXqHWdVXPxtehEOKHRygOHQ/e9sVsrpX6 jrpiPKMNhTWKN8wF8CIHGIGtfoNKA9yuR4bRYzZ/o0SeMtEoWFfu58JC7sqMBpPx7WjE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ivts4-0003xj-2k; Mon, 27 Jan 2020 03:11:24 +0100 Date: Mon, 27 Jan 2020 03:11:24 +0100 From: Andrew Lunn To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Jiri Pirko , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/7] ethtool: provide WoL settings with WOL_GET request Message-ID: <20200127021124.GF12816@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 26, 2020 at 11:11:13PM +0100, Michal Kubecek wrote: > Implement WOL_GET request to get wake-on-lan settings for a device, > traditionally available via ETHTOOL_GWOL ioctl request. > > As part of the implementation, provide symbolic names for wake-on-line Hi Michal LAN, not line. > modes as ETH_SS_WOL_MODES string set. I think it would also be good to repeat here what you have in the cover note, that unlike the ioctl version, CAP_NET_ADMIN is required. The cover note does get committed to the git history, but it is a lot less likely to be seen than this patches commit message. > +WOL_GET > +======= > + > +Query device wake-on-lan settings. Unlike most "GET" type requests, > +``ETHTOOL_MSG_WOL_GET`` requires (netns) ``CAP_NET_ADMIN`` privileges as it > +(potentially) provides SecureOn(tm) password which is confidential. provides _the_ SecureOn(tm) Apart from that: Reviewed-by: Andrew Lunn Andrew