From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, jackp@codeaurora.org,
balbi@kernel.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 04/19] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings
Date: Mon, 27 Jan 2020 12:37:05 -0600 [thread overview]
Message-ID: <20200127183705.GA30702@bogus> (raw)
In-Reply-To: <20200122185610.131930-5-bryan.odonoghue@linaro.org>
On Wed, Jan 22, 2020 at 06:55:55PM +0000, Bryan O'Donoghue wrote:
> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>
> Binding description for Qualcomm's Synopsys 1.0.0 SuperSpeed phy
> controller embedded in QCS404.
>
> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
> definitions.
>
> [bod: converted to yaml format]
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/phy/intel,lgm-emmc-phy.yaml | 56 --------------
Working around errors? Should be fixed now, but not yet in linux-next.
> .../devicetree/bindings/phy/qcom,usb-ss.yaml | 75 +++++++++++++++++++
> 2 files changed, 75 insertions(+), 56 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-ss.yaml
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-ss.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-ss.yaml
> new file mode 100644
> index 000000000000..3325b2f2e6a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-ss.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/qcom,usb-ss.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Synopsys 1.0.0 SuperSpeed USB PHY
> +
> +maintainers:
> + - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> +
> +description: |
> + Qualcomm Synopsys 1.0.0 SuperSpeed USB PHY
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,usb-ssphy
Should be SoC specific.
> +
> + reg:
> + maxItems: 1
> + description: USB PHY base address and length of the register map.
Can drop this. Doesn't really add anything.
> +
> + "#phy-cells":
> + const: 0
> + description: Should be 0. See phy/phy-bindings.txt for details.
'Should be 0' is already expressed by the schema. The remaining
reference isn't needed.
> +
> + clocks:
> + maxItems: 3
> + minItems: 3
> + description: phandles for rpmcc clock, PHY AHB clock, SuperSpeed pipe clock.
Split the description into 3 entries of 'items'. With that,
minItems/maxItems is implicit.
> +
> + clock-names:
> + items:
> + - const: ref
> + - const: phy
'ahb' seems like a better name.
> + - const: pipe
> +
> + vdd-supply:
> + maxItems: 1
Drop.
> + description: phandle to the regulator VDD supply node.
> +
> + vdda1p8-supply:
> + maxItems: 1
Drop.
> + description: phandle to the regulator 1.8V supply node.
> +
> + resets:
> + items:
> + - description: COM reset
> + - description: PHY reset line
> +
> + reset-names:
> + items:
> + - const: com
> + - const: phy
required and additionalProperties needed.
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-qcs404.h>
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> + usb3_phy: usb3-phy@78000 {
> + compatible = "qcom,usb-ssphy";
> + reg = <0x78000 0x400>;
> + #phy-cells = <0>;
> + clocks = <&rpmcc RPM_SMD_LN_BB_CLK>,
> + <&gcc GCC_USB_HS_PHY_CFG_AHB_CLK>,
> + <&gcc GCC_USB3_PHY_PIPE_CLK>;
> + clock-names = "ref", "phy", "pipe";
> + resets = <&gcc GCC_USB3_PHY_BCR>,
> + <&gcc GCC_USB3PHY_PHY_BCR>;
> + reset-names = "com", "phy";
> + vdd-supply = <&vreg_l3_1p05>;
> + vdda1p8-supply = <&vreg_l5_1p8>;
> + };
> +...
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-01-27 18:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 18:55 [PATCH v3 00/19] Enable Qualcomm QCS 404 HS/SS USB Bryan O'Donoghue
2020-01-22 18:55 ` [PATCH v3 01/19] dt-bindings: phy: remove qcom-dwc3-usb-phy Bryan O'Donoghue
2020-01-22 18:55 ` [PATCH v3 02/19] dt-bindings: phy: Add Qualcomm Synopsys Hi-Speed USB PHY binding Bryan O'Donoghue
2020-01-27 17:53 ` Rob Herring
2020-01-22 18:55 ` [PATCH v3 03/19] phy: qualcomm: Add Synopsys Hi-Speed USB PHY driver Bryan O'Donoghue
2020-01-22 18:55 ` [PATCH v3 04/19] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Bryan O'Donoghue
2020-01-27 18:37 ` Rob Herring [this message]
2020-01-22 18:55 ` [PATCH v3 05/19] phy: qualcomm: usb: Add SuperSpeed PHY driver Bryan O'Donoghue
2020-01-23 8:56 ` Philipp Zabel
2020-01-22 18:55 ` [PATCH v3 06/19] dt-bindings: usb: dwc3: Add a gpio-usb-connector description Bryan O'Donoghue
2020-01-27 18:43 ` Rob Herring
2020-02-04 23:54 ` Bryan O'Donoghue
2020-01-31 13:22 ` Felipe Balbi
2020-01-22 18:55 ` [PATCH v3 07/19] usb: dwc3: Registering a role switch in the DRD code Bryan O'Donoghue
2020-01-31 13:25 ` Felipe Balbi
2020-01-22 18:55 ` [PATCH v3 08/19] dt-bindings: usb: generic: Add role-switch-default-mode binding Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 09/19] usb: dwc3: qcom: Override VBUS when using gpio_usb_connector Bryan O'Donoghue
2020-01-31 13:26 ` Felipe Balbi
2020-01-22 18:56 ` [PATCH v3 10/19] usb: dwc3: Add support for role-switch-default-mode binding Bryan O'Donoghue
2020-01-31 13:29 ` Felipe Balbi
2020-01-31 13:43 ` Bryan O'Donoghue
2020-01-31 13:46 ` Felipe Balbi
2020-01-22 18:56 ` [PATCH v3 11/19] usb: dwc3: Add support for usb-conn-gpio connectors Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 12/19] arm64: dts: qcom: qcs404: Add USB devices and PHYs Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 13/19] arm64: dts: qcom: qcs404-evb: Define VBUS detect pin Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 14/19] arm64: dts: qcom: qcs404-evb: Define VBUS boost pin Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 15/19] arm64: dts: qcom: qcs404-evb: Define USB ID pin Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 16/19] arm64: dts: qcom: qcs404-evb: Describe external VBUS regulator Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 17/19] arm64: dts: qcom: qcs404-evb: Raise vreg_l12_3p3 minimum voltage Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 18/19] arm64: dts: qcom: qcs404-evb: Enable secondary USB controller Bryan O'Donoghue
2020-01-22 18:56 ` [PATCH v3 19/19] arm64: dts: qcom: qcs404-evb: Enable primary " Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127183705.GA30702@bogus \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=jorge.ramirez.ortiz@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).