From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: mhocko@suse.com, richardw.yang@linux.intel.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [v3 PATCH] mm: move_pages: report the number of non-attempted pages
Date: Mon, 27 Jan 2020 11:35:46 -0800 [thread overview]
Message-ID: <20200127193546.GB8708@bombadil.infradead.org> (raw)
In-Reply-To: <1580144268-79620-1-git-send-email-yang.shi@linux.alibaba.com>
> @@ -1627,8 +1627,18 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
> start = i;
> } else if (node != current_node) {
> err = do_move_pages_to_node(mm, &pagelist, current_node);
> - if (err)
> + if (err) {
> + /*
> + * Possitive err means the number of failed
"positive"
> + * pages to migrate. Since we are going to
> + * abort and return the number of non-migrated
> + * pages, so need incude the rest of the
"need to include"
> + * nr_pages that have not attempted as well.
"have not been attempted"
> @@ -1674,6 +1687,13 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>
> /* Make sure we do not overwrite the existing error */
> err1 = do_move_pages_to_node(mm, &pagelist, current_node);
> + /*
> + * Don't have to report non-attempted pages here since:
> + * - If the above loop is done gracefully there is not non-attempted
"all pages have been attempted"
> + * page.
> + * - If the above loop is aborted to it means more fatal error
s/to// s/more/a/
> + * happened, should return err.
> + */
I'd also be tempted to rename "err" to "ret" since it has meanings beyond
"error" now.
next prev parent reply other threads:[~2020-01-27 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 16:57 [v3 PATCH] mm: move_pages: report the number of non-attempted pages Yang Shi
2020-01-27 19:35 ` Matthew Wilcox [this message]
2020-01-27 19:55 ` Yang Shi
2020-01-29 10:12 ` Michal Hocko
2020-01-29 17:18 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127193546.GB8708@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=richardw.yang@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).